Skip to content

chore(pipelines): Rename Opralog user_entries to entries to match source#168

Merged
martyngigg merged 1 commit into
mainfrom
rename-opralogweb_user_entries
Dec 3, 2025
Merged

chore(pipelines): Rename Opralog user_entries to entries to match source#168
martyngigg merged 1 commit into
mainfrom
rename-opralogweb_user_entries

Conversation

@martyngigg

@martyngigg martyngigg commented Dec 3, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

No longer using the tool that prevented using the original name.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Opralogweb entries table naming and removed associated configuration workarounds from staging models.
    • Simplified source definitions by removing unused table entries.

✏️ Tip: You can customize this high-level summary in your review settings.

@martyngigg
Rename Opralog user_entries to entries to match source
687536e 
No longer using tool that prevented using the original name.
@coderabbitai

coderabbitai Bot commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Reverting a table naming workaround for the Opralogweb entries table. Renamed user_entries back to entries, removed the destination_name mapping from configuration, removed two additional tables from the source definition, and updated downstream references to use the new table and model names.

Changes

Cohort / File(s) Summary
Configuration and source definitions
warehouses/accelerator/extract_load/opralogweb/.dlt/config.toml, warehouses/accelerator/transform/accelerator/models/staging/opralogweb/_opralogweb__sources.yml		 Removed destination_name mapping and related comments from configuration. Renamed user_entries to entries in source definition. Removed more_entry_columns and additional_columns tables from source.
Staging model SQL
warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.sql, warehouses/accelerator/transform/accelerator/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.sql		 Updated dbt source reference from user_entries to entries. Updated staging query to reference base_opralogweb__entries instead of base_opralogweb__user_entries.
Model definitions
warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.yml, warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__user_entries.yml		 Created new model definition for base_opralogweb__entries with entry_id column and not_null test. Removed deprecated base_opralogweb__user_entries model definition.

Poem

🐰 From user_entries back to entries we hop,
The workaround unwinds, the renaming stops,
Clean schemas emerge, no tricks in sight,
Tables align as they should be, just right! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming the Opralog user_entries table to entries to match the source schema, with the workaround removal clearly communicated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 89a6619 and 687536e.

📒 Files selected for processing (6)
  • warehouses/accelerator/extract_load/opralogweb/.dlt/config.toml (0 hunks)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/_opralogweb__sources.yml (1 hunks)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.sql (1 hunks)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.yml (1 hunks)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__user_entries.yml (0 hunks)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.sql (1 hunks)
💤 Files with no reviewable changes (2)
  • warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__user_entries.yml
  • warehouses/accelerator/extract_load/opralogweb/.dlt/config.toml
🔇 Additional comments (4)
warehouses/accelerator/transform/accelerator/models/staging/opralogweb/stg_opralogweb__mcr_equipment_downtime.sql (1)

6-6: Verify removal of referenced base models.

The update on line 6 from base_opralogweb__user_entries to base_opralogweb__entries is correct. However, the staging SQL still references base_opralogweb__more_entry_columns (line 14) and base_opralogweb__additional_columns (line 16) without changes. The PR description claims these tables were removed from the source definition, but the source definition file still lists them. Please confirm whether these base models still exist and are valid for downstream consumption, or if they should also be removed here.

warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.sql (1)

5-5: Source reference correctly updated.

The reference to src_opralogweb.entries on line 5 aligns with the renamed source table. The column selection and transformation logic remain unchanged and correct.

warehouses/accelerator/transform/accelerator/models/staging/opralogweb/base/base_opralogweb__entries.yml (1)

1-8: New model definition is well-structured.

The new model definition correctly defines the renamed base model with appropriate metadata and a not_null test on the primary key.

warehouses/accelerator/transform/accelerator/models/staging/opralogweb/_opralogweb__sources.yml (1)

6-11: Clarify source table removal claim.

Line 6 correctly renames the table from user_entries to entries. However, the PR description states that more_entry_columns and additional_columns tables were removed from the source definition, yet lines 10-11 show these tables still present in the source file without modification markers. Please verify whether these tables should be removed. If they were indeed removed, they should not appear in this listing. If they remain, the PR description requires clarification.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@martyngigg
martyngigg merged commit 4e647bc into main Dec 3, 2025
2 checks passed
@martyngigg
martyngigg deleted the rename-opralogweb_user_entries branch December 3, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@martyngigg