fix(infra): Fix Superset docker GitHub action

[martyngigg]

Summary by CodeRabbit

Release Notes

• Chores
  • Refactored Docker image build workflow configuration to improve code clarity by replacing an environment variable with explicit inline image name construction across build and attestation steps, with no impact to functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The .github/workflows/docker-superset.yml workflow removes the reusable FQ_IMAGE_NAME environment variable declaration and replaces all occurrences with explicit inline construction of the fully-qualified Docker image name string throughout the workflow steps.

Changes

Cohort / File(s)	Change Summary
Environment variable refactoring \\.github/workflows/docker-superset.yml	Removed FQ_IMAGE_NAME environment variable from workflow env section and replaced all usages with explicit inline image name concatenation in the Build and push Docker image step and Generate artifact attestation step

Poem

🐰 A variable once lived and hopped with care,
But now its value floats on the air,
Inline and direct, no secrets to keep,
The workflow runs free whilst variables sleep! 🌙

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to fixing a Superset Docker GitHub action, which aligns with the actual changes of refactoring the docker-superset.yml workflow by removing and inlining the FQ_IMAGE_NAME variable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/docker-superset.yml (2)

43-45: Duplication of image name construction across workflow steps.

The fully-qualified Docker image name is constructed explicitly here and again at line 52. Whilst the change appears functionally correct, repeating the construction in multiple locations introduces maintenance burden—any future changes to registry, org name, or image naming scheme now require updates in multiple places.

Could you clarify whether the original FQ_IMAGE_NAME environment variable was removed to fix a specific GitHub Actions limitation or bug? If the issue is resolvable through alternative scoping or definition approaches (e.g., as a step output or run-time computed variable), consider refactoring to avoid duplication while preserving the fix.

---

52-52: Extract duplicated image name construction to reduce maintenance burden.

The subject-name replicates the same concatenation pattern as lines 44-45. This violates DRY principles. If the removal of FQ_IMAGE_NAME was necessary to fix a specific issue, consider defining the concatenated value as a reusable step output or workflow variable using alternative techniques (e.g., via a run step with echo "FQ_IMAGE=..." >> $GITHUB_OUTPUT).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between de79dee and 29eead5.

📒 Files selected for processing (1)

• .github/workflows/docker-superset.yml (1 hunks)