Skip to content

fix(infra): Fix Superset docker GitHub action #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martyngigg merged 5 commits into from
Dec 16, 2025
Merged

fix(infra): Fix Superset docker GitHub action #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29eead5
Fix Superset docker GitHub action
martyngigg Dec 15, 2025
b7ea37c
Add cancellation of old workflows when new changes are pushed
martyngigg Dec 15, 2025
3be64ee
Check GHA for changes too
martyngigg Dec 15, 2025
2c0159f
Fix image reference
martyngigg Dec 15, 2025
0f62a71
Avoid duplicating fully qualified name
martyngigg Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/docker-superset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ on:
types: [opened, synchronize, reopened]
paths:
- "infra/container-images/analytics-data-platform-superset/Dockerfile"
- ".github/workflows/docker-superset.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

env:
REGISTRY: ghcr.io
ORG_NAME: isisneutronmuon
IMAGE_NAME: analytics-data-platform-superset
FQ_IMAGE_NAME: ${{ env.REGISTRY }}/${{ env.ORG_NAME }}/${{ env.IMAGE_NAME }}
PUBLISH: false

jobs:
Expand All @@ -29,6 +33,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v5
- name: Compute fully qualified image name
run: echo "FQ_IMAGE_NAME=${{ env.REGISTRY }}/${{ env.ORG_NAME }}/${{ env.IMAGE_NAME }}" >> $GITHUB_ENV
- name: Log in to the Container registry
uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
with:
Expand All @@ -42,14 +48,14 @@ jobs:
context: infra/container-images/${{ env.IMAGE_NAME }}
push: ${{ env.PUBLISH }}
tags: |
${{ FQ_IMAGE_NAME }}:${{ github.sha }}
${{ FQ_IMAGE_NAME }}:latest
${{ env.FQ_IMAGE_NAME }}:${{ github.sha }}
${{ env.FQ_IMAGE_NAME }}:latest

# This step generates an artifact attestation for the image, which is an unforgeable statement about where and how it was built.
# See [Using artifact attestations to establish provenance for builds](/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds)
- name: Generate artifact attestation
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ FQ_IMAGE_NAME }}
subject-name: ${{ env.FQ_IMAGE_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
push-to-registry: ${{ env.PUBLISH }}
2 changes: 1 addition & 1 deletion infra/container-images/analytics-data-platform-superset/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=ghcr.io/isisneutronmuon/superset-fork:sha256-1f2019bd5a6ed81902d7c4035f0a363bceb10f60f5d9d98b4784857e2578506e
ARG BASE_IMAGE=ghcr.io/isisneutronmuon/superset-fork:1a7712b054d5cf6f15f815e79eddb6f034a5ae49
FROM ${BASE_IMAGE}

LABEL org.opencontainers.image.source=https://github.com/ISISNeutronMuon/analytics-data-platform
Expand Down