feat(infra): Publish Superset docker image on pushes to main#173
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe Docker Superset workflow configuration was modified to conditionally control image publishing. The PUBLISH variable is now set based on the current git branch, restricting publishing and attestation operations to the main branch only. Changes
Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/docker-superset.yml (1)
23-23: Excellent change to enable conditional publishing!The logic correctly restricts publishing to the main branch. However, the expression can be simplified since the comparison already returns a boolean.
Apply this diff to simplify the expression:
- PUBLISH: ${{ github.ref == 'refs/heads/main' && true || false }} + PUBLISH: ${{ github.ref == 'refs/heads/main' }}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.github/workflows/docker-superset.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/docker-superset.yml (1)
49-61: LGTM! Proper use of conditional publishing.The PUBLISH variable is correctly used to control both image pushing (line 49) and attestation publishing (line 61). This ensures that:
- On pull requests: images are built for validation but not published
- On pushes to main: images are built, published, and attested
This is the recommended pattern for secure image publishing in GitHub Actions.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.