fix(warehouses): Fix environment variable name after Opralog pipeline refactor

[martyngigg]

Summary

After refactor in #177

Summary by CodeRabbit

• Chores
  • Restructured SQL credentials environment variable configuration for improved clarity and simplicity. The credential keys have been reorganised to use a flatter, more intuitive hierarchy. Users maintaining custom environment variable configurations should review the changes and update their setup accordingly to ensure continued compatibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Restructured OPRALOGWEB SQL credential configuration keys in the environment variables template. Flattened the credential keys' hierarchical path from nested SQL_DATABASE__CREDENTIALS to a direct CREDENTIALS structure, affecting seven credential parameters without functional changes.

Changes

Cohort / File(s)	Summary
OPRALOGWEB Credential Key Hierarchy Restructuring infra/ansible-docker/playbooks/elt/templates/secrets/envvars.j2	Reorganised credential configuration keys from OPRALOGWEB__SOURCES__SQL_DATABASE__CREDENTIALS__* to OPRALOGWEB__SOURCES__CREDENTIALS__* pathway. Affects DRIVERNAME, DATABASE, SCHEMA, PORT, HOST, USERNAME, and PASSWORD attributes. Control flow and surrounding configuration remain unchanged.

Poem

🐰 Keys rearranged in structured delight,
Credentials flattened, now perfectly tight,
No more nested depths to explore,
OPRALOGWEB organised to the core,
A simpler path for secrets to store!

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing environment variable names in the Opralog pipeline configuration after a refactor.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 69dfa4a and eb13fcd.

📒 Files selected for processing (1)

• infra/ansible-docker/playbooks/elt/templates/secrets/envvars.j2

🔇 Additional comments (1)

infra/ansible-docker/playbooks/elt/templates/secrets/envvars.j2 (1)

5-11: Good that the old variable names have been completely replaced.

The old OPRALOGWEB__SOURCES__SQL_DATABASE__CREDENTIALS__* pattern has been entirely removed from the codebase, and the consuming code in warehouses/accelerator/extract_load/opralogweb/tests/test_extract_and_load.py already expects the new OPRALOGWEB__SOURCES__CREDENTIALS__* format. This confirms the migration aligns with the refactoring in PR #177.

However, note that the new structure (OPRALOGWEB__SOURCES__CREDENTIALS__*) does not follow the same pattern as the SOURCES__M365__CREDENTIALS__* variables on lines 1–3. The two employ different hierarchical structures: M365 uses a global SOURCES namespace, whilst OPRALOGWEB uses an application-level prefix with SOURCES nested within. This is not necessarily a problem, but the consistency improvement claim was inaccurate.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}