Replace @test_broken with @test ... broken = ...

Fold each `if arrayt === Array; @test ...; else @test_broken ...; end`
pair into a single `@test expr broken = (arrayt ≢ Array && ...)` form
so the array-type branching lives in the `broken` argument rather than
duplicated control flow. Drop the now-unused `@test_broken` import.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mtfishman

test/test_abstract_blocktype.jl

@@ -8,7 +8,7 @@ using MatrixAlgebraKit: eig_full, eig_trunc, eig_vals, eigh_full, eigh_trunc, ei
     right_orth, right_polar, svd_compact, svd_full, svd_trunc
 using SparseArraysBase: storedlength
 using StableRNGs: StableRNG
-using Test: @test, @test_broken, @testset
+using Test: @test, @testset
 
 elts = (Float32, Float64, ComplexF32)
 arrayts = (Array, JLArray)
@@ -60,50 +60,38 @@ arrayts = (Array, JLArray)
     a = BlockSparseMatrix{elt, AbstractMatrix{elt}}(undef, [2, 3], [2, 3])
     a[Block(1, 1)] = dev(randn(rng, elt, 2, 2))
     for f in (eig_full, eig_trunc)
-        if arrayt === Array
+        @test begin
             d, v = f(a)
-            @test a * v ≈ v * d
-        else
-            @test_broken f(a)
-        end
+            a * v ≈ v * d
+        end broken = arrayt ≢ Array
     end
-    if arrayt === Array
+    @test begin
         d = eig_vals(a)
-        @test sort(Vector(d); by = abs) ≈ sort(eig_vals(Matrix(a)); by = abs)
-    else
-        @test_broken eig_vals(a)
-    end
+        sort(Vector(d); by = abs) ≈ sort(eig_vals(Matrix(a)); by = abs)
+    end broken = arrayt ≢ Array
 
     rng = StableRNG(1234)
     a = BlockSparseMatrix{elt, AbstractMatrix{elt}}(undef, [2, 3], [2, 3])
     a[Block(1, 1)] = dev(parent(hermitianpart(randn(rng, elt, 2, 2))))
     for f in (eigh_full, eigh_trunc)
-        if arrayt === Array
+        @test begin
             d, v = f(a)
-            @test a * v ≈ v * d
-        else
-            @test_broken f(a)
-        end
+            a * v ≈ v * d
+        end broken = arrayt ≢ Array
     end
-    if arrayt === Array
+    @test begin
         d = eigh_vals(a)
-        @test sort(Vector(d); by = abs) ≈ sort(eig_vals(Matrix(a)); by = abs)
-    else
-        @test_broken eigh_vals(a)
-    end
+        sort(Vector(d); by = abs) ≈ sort(eig_vals(Matrix(a)); by = abs)
+    end broken = arrayt ≢ Array
 
     rng = StableRNG(1234)
     a = BlockSparseMatrix{elt, AbstractMatrix{elt}}(undef, [2, 3], [2, 3])
     a[Block(1, 1)] = dev(randn(rng, elt, 2, 2))
     for f in (left_orth, left_polar, qr_compact, qr_full)
         u, c = f(a)
         @test u * c ≈ a
-        if arrayt ≡ Array
-            @test isisometric(u; side = :left)
-        else
-            # TODO: Fix comparison with UniformScaling on GPU.
-            @test_broken isisometric(u; side = :left)
-        end
+        # TODO: Fix comparison with UniformScaling on GPU.
+        @test isisometric(u; side = :left) broken = arrayt ≢ Array
     end
     for f in (right_orth, right_polar, lq_compact, lq_full)
         c, u = f(a)
@@ -112,24 +100,15 @@ arrayts = (Array, JLArray)
         # reproduce `a` (regression in MatrixAlgebraKit 0.6.6, tracked at
         # https://github.com/QuantumKitHub/MatrixAlgebraKit.jl/issues/218).
         @test c * u ≈ a broken = (arrayt ≢ Array && f ∈ (right_orth, lq_compact, lq_full))
-        if arrayt ≡ Array
-            @test isisometric(u; side = :right)
-        else
-            # TODO: Fix comparison with UniformScaling on GPU.
-            @test_broken isisometric(u; side = :right)
-        end
+        # TODO: Fix comparison with UniformScaling on GPU.
+        @test isisometric(u; side = :right) broken = arrayt ≢ Array
     end
     for f in (svd_compact, svd_full, svd_trunc)
-        if arrayt ≢ Array && f ≡ svd_trunc
-            # `svd_trunc` on JLArray-backed `BlockSparseMatrix{T, AbstractMatrix{T}}`
-            # currently triggers scalar indexing on the GPU array.
-            @test begin
-                u, s, v = f(a)
-                u * s * v ≈ a
-            end broken = true
-        else
+        # `svd_trunc` on JLArray-backed `BlockSparseMatrix{T, AbstractMatrix{T}}`
+        # currently triggers scalar indexing on the GPU array.
+        @test begin
             u, s, v = f(a)
-            @test u * s * v ≈ a
-        end
+            u * s * v ≈ a
+        end broken = (arrayt ≢ Array && f ≡ svd_trunc)
     end
 end