Skip to content

Commit 8ec6fd9

Browse files
committed
Fix more tests
1 parent f1309ff commit 8ec6fd9

2 files changed

Lines changed: 16 additions & 6 deletions

File tree

src/abstractblocksparsearray/unblockedsubarray.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ function Base.Broadcast.BroadcastStyle(arraytype::Type{<:UnblockedSubArray})
3131
return BroadcastStyle(blocktype(parenttype(arraytype)))
3232
end
3333

34+
function Base.similar(a::UnblockedSubArray)
35+
return similar(a, eltype(a))
36+
end
37+
function Base.similar(a::UnblockedSubArray, elt::Type)
38+
return similar(a, elt, axes(a))
39+
end
3440
function Base.similar(
3541
a::UnblockedSubArray, elt::Type, axes::Tuple{Base.OneTo, Vararg{Base.OneTo}}
3642
)
@@ -40,6 +46,10 @@ function Base.similar(a::UnblockedSubArray, elt::Type, size::Tuple{Int, Vararg{I
4046
return similar(a, elt, Base.OneTo.(size))
4147
end
4248

49+
function Base.copyto!(dst::AbstractArray, src::UnblockedSubArray)
50+
return @invoke copyto!(dst::AbstractArray, src::AbstractArray)
51+
end
52+
4353
function ArrayLayouts.sub_materialize(a::UnblockedSubArray)
4454
a_cpu = adapt(Array, a)
4555
a_cpu′ = similar(a_cpu)

test/test_map.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -403,12 +403,12 @@ arrayts = (Array, JLArray)
403403
@test a[Block(2, 2)[1:2, 2:3]] == b
404404
@test blockstoredlength(a) == 1
405405

406-
## # Noncontiguous slicing.
407-
## a = dev(BlockSparseArray{elt}(undef, [2, 3], [2, 3]))
408-
## a[Block(1, 1)] = dev(randn(elt, 2, 2))
409-
## a[Block(2, 2)] = dev(randn(elt, 3, 3))
410-
## I = ([3, 5], [2, 4])
411-
## @test Array(a[I...]) == Array(a)[I...]
406+
# Noncontiguous slicing.
407+
a = dev(BlockSparseArray{elt}(undef, [2, 3], [2, 3]))
408+
a[Block(1, 1)] = dev(randn(elt, 2, 2))
409+
a[Block(2, 2)] = dev(randn(elt, 3, 3))
410+
I = ([3, 5], [2, 4])
411+
@test Array(a[I...]) == Array(a)[I...]
412412

413413
## # Noncontiguous slicing.
414414
## a = dev(BlockSparseArray{elt}(undef, [2, 3], [2, 3]))

0 commit comments

Comments
 (0)