blockdiagindices

Author: lkdvos

src/factorizations/eig.jl

@@ -98,8 +98,7 @@ for f in [:eig_full!, :eigh_full!]
       MatrixAlgebraKit.check_input($f, A, (D, V), alg)
 
       # do decomposition on each block
-      for I in 1:min(blocksize(A)...)
-        bI = Block(I, I)
+      for bI in blockdiagindices(A)
         if isstored(A, bI)
           block = @view!(A[bI])
           block_alg = block_algorithm(alg, block)

src/factorizations/lq.jl

@@ -99,7 +99,7 @@ function MatrixAlgebraKit.lq_compact!(
   MatrixAlgebraKit.check_input(lq_compact!, A, (L, Q), alg)
 
   # do decomposition on each block
-  for I in 1:min(blocksize(A)...)
+  for bI in blockdiagindices(A)
     bI = Block(I, I)
     if isstored(A, bI)
       block = @view!(A[bI])
@@ -131,7 +131,7 @@ function MatrixAlgebraKit.lq_full!(
 )
   MatrixAlgebraKit.check_input(lq_full!, A, (L, Q), alg)
 
-  for I in 1:min(blocksize(A)...)
+  for bI in blockdiagindices(A)
     bI = Block(I, I)
     if isstored(A, bI)
       block = @view!(A[bI])

src/factorizations/qr.jl

@@ -101,8 +101,7 @@ function MatrixAlgebraKit.qr_compact!(
   MatrixAlgebraKit.check_input(qr_compact!, A, (Q, R), alg)
 
   # do decomposition on each block
-  for I in 1:min(blocksize(A)...)
-    bI = Block(I, I)
+  for bI in blockdiagindices(A)
     if isstored(A, bI)
       block = @view!(A[bI])
       block_alg = block_algorithm(alg, block)
@@ -134,8 +133,7 @@ function MatrixAlgebraKit.qr_full!(
 )
   MatrixAlgebraKit.check_input(qr_full!, A, (Q, R), alg)
 
-  for I in 1:min(blocksize(A)...)
-    bI = Block(I, I)
+  for bI in blockdiagindices(A)
     if isstored(A, bI)
       block = @view!(A[bI])
       block_alg = block_algorithm(alg, block)

src/factorizations/svd.jl

@@ -158,8 +158,7 @@ function MatrixAlgebraKit.svd_compact!(
 )
   check_input(svd_compact!, A, (U, S, Vᴴ), alg)
 
-  for I in 1:min(blocksize(A)...)
-    bI = Block(I, I)
+  for bI in blockdiagindices(A)
     if isstored(A, bI)
       block = @view!(A[bI])
       block_alg = block_algorithm(alg, block)
@@ -195,8 +194,7 @@ function MatrixAlgebraKit.svd_full!(
 )
   check_input(svd_full!, A, (U, S, Vᴴ), alg)
 
-  for I in 1:min(blocksize(A)...)
-    bI = Block(I, I)
+  for bI in blockdiagindices(A)
     if isstored(A, bI)
       block = @view!(A[bI])
       block_alg = block_algorithm(alg, block)