File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -107,6 +107,7 @@ for f in [:eig_full!, :eigh_full!]
107107 D[bI] = bD
108108 V[bI] = bV
109109 else
110+ # TODO : this should be `V[bI] = LinearAlgebra.I`
110111 copyto! (@view! (V[bI]), LinearAlgebra. I)
111112 end
112113 end
Original file line number Diff line number Diff line change @@ -108,6 +108,7 @@ function MatrixAlgebraKit.lq_compact!(
108108 L[bI] = bL
109109 Q[bI] = bQ
110110 else
111+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
111112 copyto! (@view! (Q[bI]), LinearAlgebra. I)
112113 end
113114 end
@@ -139,6 +140,7 @@ function MatrixAlgebraKit.lq_full!(
139140 L[bI] = bL
140141 Q[bI] = bQ
141142 else
143+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
142144 copyto! (@view! (Q[bI]), LinearAlgebra. I)
143145 end
144146 end
Original file line number Diff line number Diff line change @@ -110,6 +110,7 @@ function MatrixAlgebraKit.qr_compact!(
110110 Q[bI] = bQ
111111 R[bI] = bR
112112 else
113+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
113114 copyto! (@view! (Q[bI]), LinearAlgebra. I)
114115 end
115116 end
@@ -142,6 +143,7 @@ function MatrixAlgebraKit.qr_full!(
142143 Q[bI] = bQ
143144 R[bI] = bR
144145 else
146+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
145147 copyto! (@view! (Q[bI]), LinearAlgebra. I)
146148 end
147149 end
Original file line number Diff line number Diff line change @@ -168,6 +168,7 @@ function MatrixAlgebraKit.svd_compact!(
168168 S[bI] = bS
169169 Vᴴ[bI] = bVᴴ
170170 else
171+ # TODO : this should be `U[bI] = LinearAlgebra.I` and `Vᴴ[bI] = LinearAlgebra.I`
171172 copyto! (@view! (U[bI]), LinearAlgebra. I)
172173 copyto! (@view! (Vᴴ[bI]), LinearAlgebra. I)
173174 end
@@ -204,15 +205,18 @@ function MatrixAlgebraKit.svd_full!(
204205 S[bI] = bS
205206 Vᴴ[bI] = bVᴴ
206207 else
208+ # TODO : this should be `U[bI] = LinearAlgebra.I` and `Vᴴ[bI] = LinearAlgebra.I`
207209 copyto! (@view! (U[bI]), LinearAlgebra. I)
208210 copyto! (@view! (Vᴴ[bI]), LinearAlgebra. I)
209211 end
210212 end
211213
212214 # Complete the unitaries for rectangular inputs
215+ # TODO : this should be `U[Block(I, I)] = LinearAlgebra.I`
213216 for I in (blocksize (A, 2 ) + 1 ): blocksize (A, 1 )
214217 copyto! (@view! (U[Block (I, I)]), LinearAlgebra. I)
215218 end
219+ # TODO : this should be `Vᴴ[Block(I, I)] = LinearAlgebra.I`
216220 for I in (blocksize (A, 1 ) + 1 ): blocksize (A, 2 )
217221 copyto! (@view! (Vᴴ[Block (I, I)]), LinearAlgebra. I)
218222 end
You can’t perform that action at this time.
0 commit comments