Fix @test_broken tests that now pass on Julia v1.12.6#253
Closed
Fix @test_broken tests that now pass on Julia v1.12.6#253
Conversation
Julia v1.12.6 fixed type inference for abstract array dispatch (JuliaLang/julia#57582), which makes JLArray-backed BlockSparseMatrix operations (eig, svd, qr, iszero on views) work correctly. Use `broken = gpu_broken` with a VERSION check so tests remain broken on older Julia versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
- Coverage 71.94% 5.83% -66.12%
==========================================
Files 36 35 -1
Lines 2032 1971 -61
==========================================
- Hits 1462 115 -1347
- Misses 570 1856 +1286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The JLArray operations still fail in fresh Pkg.test() processes on Julia v1.12.6; they only succeeded in a warmed REPL session. Drop the VERSION < v"1.12.6" condition and keep gpu_broken = arrayt ≠ Array. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing — this was addressing the wrong failure. The actual regression is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockSparseMatrixoperations (eig, svd, qr, iszero on views) work correctly.if arrayt === Array ... else @test_brokenbranches with@test begin ... end broken = gpu_brokenwheregpu_broken = arrayt ≠ Array && VERSION < v"1.12.6", so tests pass on v1.12.6+ and remain broken on older versions.Test plan
test_abstract_blocktype.jlpasses (252/252, 0 errors)test_map.jlpasses (2742/2742, 0 errors)🤖 Generated with Claude Code