Narrow MatrixAlgebraKit compat to pin at 0.6.4#258
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 71.99% 71.99%
=======================================
Files 36 36
Lines 2032 2032
=======================================
Hits 1463 1463
Misses 569 569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Root was aspirationally claiming `"0.6"` but test pins to `"0.6.0 - 0.6.4"` because MatrixAlgebraKit 0.6.5 has a JLArrays compat break (fixed on MatrixAlgebraKit main, not yet released). Tighten root to match reality until the fix is registered.
mtfishman
changed the title
| MacroTools = "0.5.13" | ||
| MapBroadcast = "0.1.5" | ||
| MatrixAlgebraKit = "0.6" | ||
| MatrixAlgebraKit = "0.6.0 - 0.6.4" |
There was a problem hiding this comment.
| MatrixAlgebraKit = "0.6.0 - 0.6.4" | |
| MatrixAlgebraKit = "0.6, ~0.6.5" |
It is probably cleaner to specify this like so, this has the same behavior for now and immediately fixes the problem in the future. I'm hoping to get a MatrixAlgebraKit release in this week, so that should also unblock this :)
There was a problem hiding this comment.
I actually meant to revert this, I really just wanted the test/Project.toml to skip v0.6.5, but that's a good idea to only skip v0.6.5 rather than limiting to 0.6.0 - 0.6.4. However, I don't understand your suggestion, I don't see how that would skip v0.6.5.
There was a problem hiding this comment.
I always forget the exact syntax, this was meant to be 0.6 and NOT 0.6.5
Follow-up to #258. Under the bucket-rule compat check ([ITensorActions#79](ITensor/ITensorActions#79)), within-bucket gaps no longer fail, so root can go back to `"0.6"` instead of the narrow `"0.6.0 - 0.6.4"`. `test/Project.toml` still needs to exclude MatrixAlgebraKit 0.6.5 because of its JLArrays compat break. Switching from `"0.6.0 - 0.6.4"` to `"0.6.0 - 0.6.4, 0.6.6"` lets the resolver auto-pick up 0.6.6 as soon as it's registered, with no further compat bump required here. The trailing `"0.6.6"` uses bare caret semver (`[0.6.6, 0.7.0)`) so it stays in the 0.6 bucket — `">=0.6.6"` would also admit 0.7+. Closes #259. ### Changes - root: `MatrixAlgebraKit = "0.6.0 - 0.6.4"` → `"0.6"` - test: `MatrixAlgebraKit = "0.6.0 - 0.6.4"` → `"0.6.0 - 0.6.4, 0.6.6"` - Patch version bump. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 participants
Root
[compat]was claiming support for the whole 0.6 series ("0.6") whiletest/Project.tomlpinned to"0.6.0 - 0.6.4". That gap makes the compat-bounds check fail: the root's upper bound (0.6.5) is not reachable in the workspace resolver (since test caps at 0.6.4).The right fix is to narrow root to match test, since MatrixAlgebraKit 0.6.5 has a JLArrays compat break (fix is on MatrixAlgebraKit main but not yet registered). Once a fix is released (0.6.6), both root and test can widen back to
"0.6".Changes
MatrixAlgebraKit = "0.6"→"0.6.0 - 0.6.4"0.10.37→0.10.38