Widen root MatrixAlgebraKit to "0.6"; exclude only 0.6.5 in test#260
Merged
Widen root MatrixAlgebraKit to "0.6"; exclude only 0.6.5 in test#260
Conversation
Under the bucket-rule compat check (ITensorActions#79), within-bucket gaps no longer fail. Root "0.6" vs test resolving at 0.6.4 is the same 0.6 breaking bucket, so root can go back to "0.6". Test stays pinned away from the broken MatrixAlgebraKit 0.6.5 (JLArrays compat break), but now uses "0.6.0 - 0.6.4, 0.6.6" so the resolver will automatically pick up 0.6.6 when it's released without needing another compat bump here. The trailing "0.6.6" is caret-expanded to [0.6.6, 0.7.0), so it stays in the 0.6 bucket (not ">=0.6.6", which would also admit 0.7+). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 71.99% 71.99%
=======================================
Files 36 36
Lines 2032 2032
=======================================
Hits 1463 1463
Misses 569 569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #258. Under the bucket-rule compat check (ITensorActions#79), within-bucket gaps no longer fail, so root can go back to
"0.6"instead of the narrow"0.6.0 - 0.6.4".test/Project.tomlstill needs to exclude MatrixAlgebraKit 0.6.5 because of its JLArrays compat break. Switching from"0.6.0 - 0.6.4"to"0.6.0 - 0.6.4, 0.6.6"lets the resolver auto-pick up 0.6.6 as soon as it's registered, with no further compat bump required here. The trailing"0.6.6"uses bare caret semver ([0.6.6, 0.7.0)) so it stays in the 0.6 bucket —">=0.6.6"would also admit 0.7+.Closes #259.
Changes
MatrixAlgebraKit = "0.6.0 - 0.6.4"→"0.6"MatrixAlgebraKit = "0.6.0 - 0.6.4"→"0.6.0 - 0.6.4, 0.6.6"