Bump compat for SUNRepresentations to 0.4#161
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 87.18% 87.18%
=======================================
Files 20 20
Lines 1264 1264
=======================================
Hits 1102 1102
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUNRepresentations 0.4 removed the un-parameterized SUNIrrep(...)
constructor — it now throws and requires SUNIrrep{N}(...). The ext
code was using SUNIrrep((λ..., 0)), so the extension failed to load
against 0.4. Add the {N} parameterization; still works against 0.3
because {N} dispatch was always available there.
c.I continues to work in 0.4 via a Base.getproperty backwards-compat
shim that returns the weight, so sector_label stays unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens SUNRepresentations compat from
"0.3"to"0.3, 0.4"in both root andtest/Project.toml, plus one ext fix needed for the 0.4 API change.Ext change
SUNRepresentations 0.4 removed the un-parameterized
SUNIrrep(...)constructor — it now throws and requiresSUNIrrep{N}(...). The extension was usingSUNIrrep((λ..., 0))which worked in 0.3 but breaks in 0.4. Fix:SUNIrrep{N}((λ..., 0))— compatible with both 0.3 and 0.4.c.Icontinues to work in 0.4 via aBase.getpropertybackwards-compat shim that returns the weight, sosector_labelis unchanged.Changes
SUNIrrep((λ..., 0))→SUNIrrep{N}((λ..., 0))SUNRepresentations = "0.3"→"0.3, 0.4"SUNRepresentations = "0.3"→"0.3, 0.4"0.8.4→0.8.5Smoke-tested locally: the SU tests (
test_sectors.jl,test_fusion_rule.jl) all pass against SUNRepresentations 0.4.