Skip to content

Bump compat for SUNRepresentations to 0.4#161

Merged
mtfishman merged 2 commits into
mainfrom
mf/bump-sunrepresentations-0.4
Apr 23, 2026
Merged

Bump compat for SUNRepresentations to 0.4#161
mtfishman merged 2 commits into
mainfrom
mf/bump-sunrepresentations-0.4

Conversation

@mtfishman
Copy link
Copy Markdown
Member

@mtfishman mtfishman commented Apr 23, 2026

Widens SUNRepresentations compat from "0.3" to "0.3, 0.4" in both root and test/Project.toml, plus one ext fix needed for the 0.4 API change.

Ext change

SUNRepresentations 0.4 removed the un-parameterized SUNIrrep(...) constructor — it now throws and requires SUNIrrep{N}(...). The extension was using SUNIrrep((λ..., 0)) which worked in 0.3 but breaks in 0.4. Fix: SUNIrrep{N}((λ..., 0)) — compatible with both 0.3 and 0.4.

c.I continues to work in 0.4 via a Base.getproperty backwards-compat shim that returns the weight, so sector_label is unchanged.

Changes

  • ext/GradedArraysSUNRepresentationsExt/GradedArraysSUNRepresentationsExt.jl: SUNIrrep((λ..., 0))SUNIrrep{N}((λ..., 0))
  • Project.toml: SUNRepresentations = "0.3""0.3, 0.4"
  • test/Project.toml: SUNRepresentations = "0.3""0.3, 0.4"
  • Project.toml: version 0.8.40.8.5

Smoke-tested locally: the SU tests (test_sectors.jl, test_fusion_rule.jl) all pass against SUNRepresentations 0.4.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.18%. Comparing base (18c37c5) to head (fcc64fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files          20       20           
  Lines        1264     1264           
=======================================
  Hits         1102     1102           
  Misses        162      162           
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SUNRepresentations 0.4 removed the un-parameterized SUNIrrep(...)
constructor — it now throws and requires SUNIrrep{N}(...). The ext
code was using SUNIrrep((λ..., 0)), so the extension failed to load
against 0.4. Add the {N} parameterization; still works against 0.3
because {N} dispatch was always available there.

c.I continues to work in 0.4 via a Base.getproperty backwards-compat
shim that returns the weight, so sector_label stays unchanged.
@mtfishman mtfishman merged commit 436727d into main Apr 23, 2026
17 checks passed
@mtfishman mtfishman deleted the mf/bump-sunrepresentations-0.4 branch April 23, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant