Followup cleanup from type redesign PR#149
Merged
Merged
Conversation
- Delete `view!` definitions; blocks either exist or error - Simplify `getindex` for unstored blocks to error via `copy(view(...))` - Redesign `AbelianSectorArray` undef constructor to accept `SectorOneTo` axes - Add `AbelianSectorVector` type alias - Remove `datalengths(::AbelianSectorArray)` (not needed on single-block types) - Fix `sectoraxes(::AbelianSectorArray)` to delegate through `sector()` - Rename `sector_type` → `sectortype` (consistent with `blocktype`, `sectorlength`) - Rewrite `Base.axes(::AbelianSectorArray)` in terms of `sectoraxes`/`dataaxes` - Delete `sectorrange()` constructor; use `SectorOneTo` directly - Rename `⊗` parameter from `A` to `s` - Remove unused `similar` methods on `AbelianSectorDelta` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 85.18% 85.52% +0.33%
==========================================
Files 19 19
Lines 1134 1112 -22
==========================================
- Hits 966 951 -15
+ Misses 168 161 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view!definitions; blocks either exist or errorgetindexfor unstored blocks to error viacopy(view(...))AbelianSectorArrayundef constructor to acceptSectorOneToaxesAbelianSectorVectortype aliasdatalengths(::AbelianSectorArray)(not needed on single-block types)sectoraxes(::AbelianSectorArray)to delegate throughsector()sector_type→sectortype(consistent withblocktype,sectorlength)Base.axes(::AbelianSectorArray)in terms ofsectoraxes/dataaxessectorrange()constructor; useSectorOneTodirectly⊗parameter fromAtossimilarmethods onAbelianSectorDeltaTest plan
Pkg.test()passes (all 17 test files, 0 failures)🤖 Generated with Claude Code