Drop eager permuteddims overloads now that broadcasting lowers through bipermutedimsopadd!#177
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 83.28% 83.37% +0.08%
==========================================
Files 22 22
Lines 1777 1774 -3
==========================================
- Hits 1480 1479 -1
+ Misses 297 295 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…h bipermutedimsopadd! Removes the eager FunctionImplementations.permuteddims overloads on AbstractGradedArray, AbstractSectorArray, and AbstractSectorDelta. These existed only to align graded operands during NamedDimsArrays broadcasting by materializing a permuted copy. NamedDimsArrays now aligns lazily and lowers linear broadcasts through bipermutedimsopadd!, so a permuted graded operand reaches the block-wise bipermutedimsopadd! without the eager copy. Bumps the TensorAlgebra and NamedDimsArrays compat floors to the versions that introduce that path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mtfishman
force-pushed
the
mf/drop-sector-permuteddims
branch
from
June 17, 2026 22:41
3d2a009 to
23f44ff
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mtfishman
changed the title
mtfishman
marked this pull request as ready for review
June 17, 2026 23:32
mtfishman
enabled auto-merge (squash)
June 17, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the eager
FunctionImplementations.permuteddimsoverloads onAbstractGradedArray,AbstractSectorArray, andAbstractSectorDelta. These existed only to align graded operands duringNamedDimsArraysbroadcasting by materializing a permuted copy.NamedDimsArraysnow aligns lazily and lowers linear broadcasts throughbipermutedimsopadd!(ITensor/TensorAlgebra.jl#178, ITensor/NamedDimsArrays.jl#232), so a permuted graded operand reaches the block-wisebipermutedimsopadd!without the eager copy.Bumps the
TensorAlgebraandNamedDimsArrayscompat floors to the versions that introduce that path.