CompatHelper: bump compat for JuliaSyntax to 1, (keep existing compat)#52
Closed
mtfishman wants to merge 1 commit into
Closed
CompatHelper: bump compat for JuliaSyntax to 1, (keep existing compat)#52mtfishman wants to merge 1 commit into
mtfishman wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 9 9
Lines 392 392
=======================================
Hits 338 338
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
added a commit
to ITensor/ITensorActions
that referenced
this pull request
Apr 23, 2026
## Summary Skip \`force_latest_compatible_version\` on the LTS leg of the Tests matrix. Keep the default (\`auto\`) on current Julia. ## Why \`julia-actions/julia-runtest\`'s default is \`force_latest_compatible_version: auto\`, which pins each dep to the upper end of its declared compat on bot- authored PRs — so CompatHelper bumps are actually exercised against the new version instead of resolving vacuously. That's the correct behavior on current Julia. On LTS it produces spurious failures whenever a transitive dep hasn't caught up. Concrete example: [ITensorFormatter.jl#52](ITensor/ITensorFormatter.jl#52) widens \`JuliaSyntax\` compat to \`\"0.4.10, 1\"\`, but \`JuliaFormatter 2.3\` (the only version compatible on LTS) pins JuliaSyntax to \`0.4.10\` — forcing \`1\` on LTS makes it unsatisfiable. Tests on current Julia pass; tests on LTS fail as unresolvable. In many cases we're fine with a bump being aspirational on LTS while working on current Julia. Without this change those PRs can never merge unless the entire upstream LTS chain also catches up — which we can't always control. ## Result - **Current Julia**: \`auto\` as before — bump PRs still verified against the claimed latest version. - **LTS**: resolves to whatever's reachable; tests still run, just not pinned to the upper-end compat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
JuliaSyntaxpackage from0.4.10to0.4.10, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.