Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 72.52% 72.48% -0.04%
==========================================
Files 67 67
Lines 3177 3177
==========================================
- Hits 2304 2303 -1
- Misses 873 874 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…st, (keep existing compat)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
force-pushed
the
compathelper/new_version/2026-04-26-03-52-24-112-01261198794
branch
from
e38ce57 to
11b708c
Compare
`DataStructures` was narrowed to `"0.18"` in #328 because the `EinExprs` weakdep pinned it that way. The `EinExprs` dependency was removed in #327, but the narrowed `DataStructures` compat was never reverted (and `DataStructures` itself is no longer `using`'d anywhere in `src/`, `ext/`, or `test/`). Drop the entry entirely from `[deps]` and `[compat]`. This also unblocks `OrdinaryDiffEqTsit5 = "1.1, 2"` resolution: the v2 chain pulls in `OrdinaryDiffEqCore` 4, which requires `DataStructures` 1.x-3.x and was previously incompatible with the 0.18 pin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
deleted the
compathelper/new_version/2026-04-26-03-52-24-112-01261198794
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
OrdinaryDiffEqTsit5package from1.1to1.1, 2for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.