Upgrade ITensorNetworks to use DataGraphs v0.4.0 and NamedGraphs v0.11.0.#317
Merged
mtfishman merged 18 commits intoITensor:mainfrom Apr 28, 2026
Merged
Upgrade ITensorNetworks to use DataGraphs v0.4.0 and NamedGraphs v0.11.0.#317mtfishman merged 18 commits intoITensor:mainfrom
mtfishman merged 18 commits intoITensor:mainfrom
Conversation
DMRG Callback (ITensor#304) Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
jack-dunham
force-pushed
the
datagraphs-namedgraphs
branch
from
2364c41 to
da20b0f
Compare
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
jack-dunham
force-pushed
the
datagraphs-namedgraphs
branch
from
a950308 to
fc2993e
Compare
…r vertex presence rather than if vertex is assigned.
jack-dunham
force-pushed
the
datagraphs-namedgraphs
branch
from
fc2993e to
f02b759
Compare
Member
|
@jack-dunham can you look into the version, format, and docs failures? |
Contributor
Author
|
Yes, I am just waiting for the tests to pass locally. |
Member
|
(The docs failures are a bit odd, they may be related to ITensor/ITensors.jl#1729 so I can look into that in parallel as well, but please do take a look.) |
mtfishman
reviewed
Apr 27, 2026
…sorNetwork` resulting in empty tensors.
jack-dunham
force-pushed
the
datagraphs-namedgraphs
branch
from
63f7986 to
f411df7
Compare
mtfishman
reviewed
Apr 28, 2026
| # | ||
|
|
||
| ITensorNetwork(tn::AbstractTTN) = error("Not implemented") | ||
| itensornetwork(tn::AbstractTTN) = error("Not implemented") |
mtfishman
reviewed
Apr 28, 2026
| using ITensors.ITensorVisualizationCore: ITensorVisualizationCore, visualize | ||
| function ITensorVisualizationCore.visualize(is::IndsNetwork, args...; kwargs...) | ||
| return visualize(ITensorNetwork(is), args...; kwargs...) | ||
| return visualize(tensornetwork(is), args...; kwargs...) |
Member
There was a problem hiding this comment.
Same thing here, this looks like a mistake.
Member
|
Thanks Jack, glad to see this getting in! |
This was referenced Apr 28, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package now used the proper
AbstractDataGraphinterface from DataGraphs, and thesimilar_graphinterface fromNamedGraphs.