Narrow compat on Graphs, OMEinsumContractionOrders, DataStructures, OrdinaryDiffEqTsit5 to match resolver#326
Closed
mtfishman wants to merge 1 commit into
Closed
Narrow compat on Graphs, OMEinsumContractionOrders, DataStructures, OrdinaryDiffEqTsit5 to match resolver#326mtfishman wants to merge 1 commit into
mtfishman wants to merge 1 commit into
Conversation
…rdinaryDiffEqTsit5 to match resolver These compat entries claimed support for versions the workspace resolver can't actually reach (external transitive constraints keep Graphs at 1.13, OMEinsumContractionOrders at 1.2.2, DataStructures at 0.18, OrdinaryDiffEqTsit5 at 1.10). Tighten to match reality so Check Compat Bounds passes; widen back whenever upstream constraints loosen. Root, docs, and test are aligned to the same compat ranges for each dep that appears in multiple subprojects.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 71.45% 69.10% -2.35%
==========================================
Files 81 81
Lines 4029 4027 -2
==========================================
- Hits 2879 2783 -96
- Misses 1150 1244 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Superseded by ITensorActions#78, which changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check Compat Boundscheck was flagging that several compat entries claim support for versions the workspace resolver can't reach (transitive constraints in external deps keep them pinned lower). Reconcile by narrowing the claims to match reality; widen back when upstream constraints loosen.Changes
Unified across root + docs + test where the entry appears in multiple subprojects:
Graphs: root"1.8", docs"1", test"1.12"→ all"1.8 - 1.13"(resolver reaches 1.13.1)OMEinsumContractionOrders: root"0.8.3, 0.9, 1", docs"1.2.2"(caret, allows 1.2.3), test"0.9.5, 1"→ all"0.8.3, 0.9, 1 - 1.2.2"Root-only:
DataStructures:"0.18, 0.19"→"0.18"(resolver reaches 0.18.22; 0.19.x unreachable)Test-only:
OrdinaryDiffEqTsit5:"1.1"→"1.1 - 1.10"(resolver reaches 1.10.0)Plus patch version bump.
See
ITensorDevelopmentPlans/Projects/Ecosystem/compat_bounds_debt/for the "test-stricter-than-root" antipattern framing this addresses.🤖 Generated with Claude Code