Drop orphaned ITensorNetworksObserversExt#357
Merged
Conversation
PR #354 removed `update_observer!` from ITensorNetworks but left `ext/ITensorNetworksObserversExt/` and its `Observers` weakdep wired up. Since v0.20.0, any environment loading both ITensorNetworks and Observers hits a precompile error: `UndefVarError: update_observer! not defined in ITensorNetworks`. This breaks downstream packages that depend on Observers (e.g. Tennis.jl). Drop the extension directory, the Observers weakdep, the extension entry, and the Observers compat bound. Also drop Observers from `test/Project.toml` since no test files reference it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 74.60% 74.62% +0.01%
==========================================
Files 64 63 -1
Lines 3103 3101 -2
==========================================
- Hits 2315 2314 -1
+ Misses 788 787 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_observer!from ITensorNetworks but left theITensorNetworksObserversExtweak-dependency extension still wired up. Since v0.20.0, any environment that loads ITensorNetworks alongside Observers fails to precompile withUndefVarError: \update_observer!` not defined in `ITensorNetworks``. This blocks downstream packages that depend on Observers (e.g. Tennis.jl).ext/ITensorNetworksObserversExt/directory, theObserversweakdep, the corresponding[extensions]entry, and theObserverscompat bound. Also dropObserversfromtest/Project.toml(no test files reference it).0.21.1(patch — no public API change beyond the dead-code extension).