Fix algorithms interface using legacy finalize_substate signature.

jack-dunham · jack-dunham · commit 798d34420dca · 2026-06-01T17:40:45.000-04:00
diff --git a/src/AlgorithmsInterfaceExtensions/AlgorithmsInterfaceExtensions.jl b/src/AlgorithmsInterfaceExtensions/AlgorithmsInterfaceExtensions.jl
@@ -58,7 +58,7 @@ end
 function AI.step!(problem::AI.Problem, algorithm::NestedAlgorithm, state::AI.State)
     subproblem, subalgorithm, substate = initialize_subsolve(problem, algorithm, state)
     AI.solve!(subproblem, subalgorithm, substate)
-    finalize_substate!(problem, algorithm, substate, state)
+    finalize_substate!(subproblem, subalgorithm, substate, state)
     return state
 end
 
diff --git a/test/test_algorithmsinterfaceextensions.jl b/test/test_algorithmsinterfaceextensions.jl
@@ -115,7 +115,7 @@ end
         # `finalize_substate!` copies the substate's iterate back into the
         # parent state.
         substate = AI.initialize_state(problem, algorithm; iterate = [42.0])
-        AIE.finalize_substate!(problem, algorithm, state, substate)
+        AIE.finalize_substate!(problem, algorithm, substate, state)
         @test state.iterate == [42.0]
     end
 
diff --git a/test/test_beliefpropagation.jl b/test/test_beliefpropagation.jl
@@ -229,7 +229,7 @@ end
 
             cache = ITensorNetworksNext.beliefpropagation(
                 tn, messages, partitions;
-                stopping_criterion = (; maxiter = 10, tol = 1.0e-10)
+                stopping_criterion = (; maxiter = 30, tol = 1.0e-10)
             )
 
             z_bp = exp(bethe_free_energy(tn, cache))

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ end`
`229`	`229`
`230`	`230`	`cache = ITensorNetworksNext.beliefpropagation(`
`231`	`231`	`tn, messages, partitions;`
`232`		`- stopping_criterion = (; maxiter = 10, tol = 1.0e-10)`
	`232`	`+ stopping_criterion = (; maxiter = 30, tol = 1.0e-10)`
`233`	`233`	`)`
`234`	`234`
`235`	`235`	`z_bp = exp(bethe_free_energy(tn, cache))`