Revised Belief Propagation #26
Open
jack-dunham wants to merge 68 commits intoITensor:mainfrom
Open
Conversation
Introduce `BeliefPropagationProblem` wrapper to hold the cache and the error `diff` field. Also simplifies some kwargs wrangling.
…be set from another cache
Also includes some fixes to the way `TensorNetwork` types are constructed based on index structure.
for more information, see https://pre-commit.ci
…instead of trying to operate on existing graphs The reason for this is: - One only cares about the edges of the input graph - A simple graph cannot be used as it "forgets" its edge names resulting in recursion - As shown with `TensorNetwork`, removing edges may not always be defined.
…s from an array.
This was caused by the change to the `cache` being backed by a directed graph.
mtfishman
reviewed
Apr 20, 2026
mtfishman
reviewed
Apr 20, 2026
Comment on lines
+155
to
+156
| array = ones(Tuple(inds(src) ∩ inds(dst))) | ||
| return convert(T, array) |
Member
There was a problem hiding this comment.
I think this may be slightly better as a code pattern for this:
Suggested change
| array = ones(Tuple(inds(src) ∩ inds(dst))) | |
| return convert(T, array) | |
| return fill!(similar(T, Tuple(inds(src) ∩ inds(dst))), true) |
There's a subtlety here when dealing with QN conserving and fermionic tensors, but I think this is a reasonable start and we can discuss that later.
An idea I've brought with with Joey is to use a randomized SVD or QR of the factor to get a better guess for the message. Again, not something for this PR but I wanted to bring it up as something to keep in mind.
mtfishman
reviewed
Apr 20, 2026
mtfishman
reviewed
Apr 20, 2026
mtfishman
reviewed
Apr 20, 2026
mtfishman
reviewed
Apr 20, 2026
mtfishman
reviewed
Apr 20, 2026
Member
|
@jack-dunham can you resolve comments that you've addressed so it is easier to track what remains? Also can you rebase on main and format to get tests running cleanly? |
…`BeliefPropagationCache`.
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
This method was just forwarding the underlying graph.
An `AbstractTensorNetwork` has edge type `Nothing`, which can be obtained from the `AbstractDataGraph` method.
mtfishman
dismissed
JoeyT1994’s stale review
Joey's requests mostly complete as far as I know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR express belief propagation in terms of the new interface based on AlgorithmsInterface.jl and the included AlgorithmsInterfaceExtensions.jl library.