Drop paths filter from IntegrationTest trigger#126
Merged
Conversation
Remove paths: ["Project.toml"] from both the push: and pull_request_target: triggers of IntegrationTest.yml, in both the template and the installed workflow. Previously, PRs that did not touch Project.toml did not trigger the workflow at all, which left the required IntegrationTest check hanging on "Waiting for status to be reported" in branch protection. Now IntegrationTest runs on every non-draft PR; drafts continue to skip the downstream matrix via the reusable workflow's run-on-draft: false default. Running integration tests on workflow-only PRs is the safer default since workflow edits can affect how the tests run.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 1 1
Lines 158 158
=======================================
Hits 138 138
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paths: ["Project.toml"]from both thepush:andpull_request_target:triggers ofIntegrationTest.yml, in the template and the installed workflow.Motivation
Previously, PRs that didn't touch
Project.tomldidn't trigger the workflow at all, leaving the requiredIntegrationTestbranch-protection context hanging on "Waiting for status to be reported" (e.g. ITensor/ITensorDocs.jl#49, ITensor/ITensorDocsNext.jl#44).Now
IntegrationTestruns on every non-draft PR; drafts continue to skip the downstream matrix via the reusable workflow'srun-on-draft: falsedefault. Draft/ready-for-review is the right knob to control running the downstream tests. Running integration tests on workflow-only PRs is the safer default since workflow edits can affect how the tests run.Follow-up
A companion MassApplyPatch (
integrationtest_drop_paths_filterin ITensorOrgPatches) will propagate this change to the 27 ecosystem repos.Test plan
IntegrationTestsuccessfully on the skeleton repo.IntegrationTestcheck.🤖 Generated with Claude Code