Skip to content

Fix nested LittleSet; add type-domain methods to nametype and denamedtype for NamedDimsArray.#222

Merged
mtfishman merged 4 commits into
mainfrom
jd.littleset-fix
May 6, 2026
Merged

Fix nested LittleSet; add type-domain methods to nametype and denamedtype for NamedDimsArray.#222
mtfishman merged 4 commits into
mainfrom
jd.littleset-fix

Conversation

@jack-dunham
Copy link
Copy Markdown
Contributor

@jack-dunham jack-dunham commented May 5, 2026

These changes are required for the revamp of the TensorNetwork (specifically the reverse index mapping).

Should fix: ITensor/ITensorBase.jl#159

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.00%. Comparing base (81accd0) to head (771e411).

Files with missing lines Patch % Lines
src/nameddimsarray.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   70.88%   71.00%   +0.12%     
==========================================
  Files          20       20              
  Lines         965      969       +4     
==========================================
+ Hits          684      688       +4     
  Misses        281      281              
Flag Coverage Δ
docs 17.69% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Copy Markdown
Member

Thanks!

@mtfishman mtfishman merged commit 633d507 into main May 6, 2026
22 checks passed
@mtfishman mtfishman deleted the jd.littleset-fix branch May 6, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling dimnames on an ITensor can result in nested LittleSet objects.

2 participants