Skip to content

Rename contract! to contractadd! when α, β are specified#82

Merged
mtfishman merged 8 commits into
mainfrom
mf/contractadd
Sep 11, 2025
Merged

Rename contract! to contractadd! when α, β are specified#82
mtfishman merged 8 commits into
mainfrom
mf/contractadd

Conversation

@mtfishman

Copy link
Copy Markdown
Member

Also remove the version of contract accepting α (which was causing ambiguity errors) and rename unmatricize_add! to unmatricizeadd! to match the new naming convention of contractadd!.

@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.82%. Comparing base (5873db1) to head (dbe4ee6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/TensorAlgebraTensorOperationsExt.jl 80.00% 1 Missing ⚠️
src/contract/contract.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   91.16%   92.82%   +1.66%     
==========================================
  Files          15       15              
  Lines         498      502       +4     
==========================================
+ Hits          454      466      +12     
+ Misses         44       36       -8     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Project.toml Outdated
@mtfishman mtfishman merged commit 063a107 into main Sep 11, 2025
17 checks passed
@mtfishman mtfishman deleted the mf/contractadd branch September 11, 2025 20:46
@mtfishman

Copy link
Copy Markdown
Member Author

@ogauthe note the interface change, it might require some small updates to FusionTensors.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant