Fix /cosmetics main menu categories not opening - #72
Open
GenOpenDiesel wants to merge 1 commit into
Open
Conversation
CosmeticsType.fromName only matched exact enum names, so Main-Menu.yml entries like Victory-Dances never opened. Also harden CategoryMenu slots parsing and DeathCrySBW ScreamingBedWars compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CosmeticsType.fromNameso hyphenated Main-Menu.yml keys (Victory-Dances,Projectile-Trails,Bed-Destroys, etc.) correctly open category menusCategoryMenuslots parsing whenslotsis missing/invalidsetPlaySoundso the plugin builds against older API jarsTest plan
/cosmeticsand click every category (Victory Dances, Projectile Trails, Final Kill Effects, Kill Messages, Bed Destroys, Death Cries, and the ones that already worked)Made with Cursor