feat: add support for QuickJS rope strings

Author: Icemic

libquickjs-sys/embed/quickjs

@@ -174,6 +174,7 @@ impl<'de, 'a> de::Deserializer<'de> for &'a mut Deserializer<'de> {
             JsTag::Bool => visitor.visit_bool(current.to_bool()?),
             JsTag::Null => visitor.visit_unit(),
             JsTag::String => visitor.visit_string(current.to_string()?),
+            JsTag::RopeString => visitor.visit_string(current.to_string()?),
             JsTag::Float64 => visitor.visit_f64(current.to_float()?),
             JsTag::Object => {
                 if current.is_array() {

src/serde/de.rs

@@ -12,6 +12,7 @@ pub enum JsTag {
     BigInt = q::JS_TAG_BIG_INT,
     Symbol = q::JS_TAG_SYMBOL,
     String = q::JS_TAG_STRING,
+    RopeString = q::JS_TAG_STRING_ROPE,
     Module = q::JS_TAG_MODULE,
     FunctionBytecode = q::JS_TAG_FUNCTION_BYTECODE,
     Object = q::JS_TAG_OBJECT,
@@ -39,6 +40,7 @@ impl JsTag {
             q::JS_TAG_MODULE => JsTag::Module,
             q::JS_TAG_OBJECT => JsTag::Object,
             q::JS_TAG_STRING => JsTag::String,
+            q::JS_TAG_STRING_ROPE => JsTag::RopeString,
             q::JS_TAG_SYMBOL => JsTag::Symbol,
             q::JS_TAG_FLOAT64 => JsTag::Float64,
             q::JS_TAG_EXCEPTION => JsTag::Exception,
@@ -65,6 +67,7 @@ impl JsTag {
             JsTag::BigInt => q::JS_TAG_FUNCTION_BYTECODE,
             JsTag::Symbol => q::JS_TAG_SYMBOL,
             JsTag::String => q::JS_TAG_STRING,
+            JsTag::RopeString => q::JS_TAG_STRING_ROPE,
             JsTag::Module => q::JS_TAG_MODULE,
             JsTag::FunctionBytecode => q::JS_TAG_FUNCTION_BYTECODE,
             JsTag::Object => q::JS_TAG_OBJECT,

src/value/tag.rs

@@ -251,7 +251,7 @@ impl OwnedJsValue {
     /// Check if this value is a Javascript string.
     #[inline]
     pub fn is_string(&self) -> bool {
-        self.tag() == JsTag::String
+        unsafe { q::JS_Ext_IsString(self.value) }
     }
 
     /// Check if this value is a bytecode compiled function.
@@ -292,7 +292,8 @@ impl OwnedJsValue {
 
     /// Convert this value into a string
     pub fn to_string(&self) -> Result<String, ValueError> {
-        self.check_tag(JsTag::String)?;
+        self.check_tag(JsTag::String)
+            .or_else(|_| self.check_tag(JsTag::RopeString))?;
         let ptr =
             unsafe { q::JS_ToCStringLen2(self.context, std::ptr::null_mut(), self.value, false) };
 

src/value/value.rs

@@ -30,6 +30,17 @@ fn test_try_from_owned_js_value() {
     let value: String = js_value.try_into().unwrap();
     assert_eq!(value, "hello");
 
+    // test with rope string
+    let js_value: OwnedJsValue = context
+        .eval(
+            &format!("var x = `{}`; x + x", include_str!("fixtures/long_string.txt")),
+            false,
+        )
+        .unwrap();
+    assert!(js_value.is_string());
+    let value: String = js_value.try_into().unwrap();
+    assert!(value.starts_with("Lorem ipsum"));
+
     let js_value: OwnedJsValue = context.eval(r#"({"key": "value"})"#, false).unwrap();
     let value: HashMap<String, String> = js_value.try_into().unwrap();
     assert_eq!(value, HashMap::from([("key".into(), "value".into())]));