Merge pull request #158 from Icinga/fix/config-forms

Fix config forms

Author: lippserd

application/controllers/ConfigController.php

@@ -119,6 +119,7 @@ function (NotificationsConfigForm $form) use ($sourceForm) {
 
                     if (
                         $source === null
+                        || ! isset($kconfig[KConfig::NOTIFICATIONS_PASSWORD])
                         // Must be kept in sync with SourceForm.
                         || password_hash(
                             $kconfig[KConfig::NOTIFICATIONS_PASSWORD]->value,

application/forms/PrometheusConfigForm.php

@@ -100,7 +100,6 @@ protected function assemble(): void
             KConfig::transformKeyForForm(KConfig::PROMETHEUS_URL),
             [
                 'label'    => $this->translate('URL'),
-                'required' => true,
                 'value'    => $kconfig[KConfig::PROMETHEUS_URL]->value ?? null,
                 'disabled' => $kconfig[KConfig::PROMETHEUS_URL]->locked ?? false,
                 'ignore'   => $kconfig[KConfig::PROMETHEUS_URL]->locked ?? false,
@@ -114,7 +113,7 @@ protected function assemble(): void
                 'label'          => $this->translate('Insecure'),
                 'checkedValue'   => 'true',
                 'uncheckedValue' => 'false',
-                'value'          => $kconfig[KConfig::PROMETHEUS_INSECURE]?->value === 'true',
+                'value'          => $kconfig[KConfig::PROMETHEUS_INSECURE]->value ?? null === 'true',
                 'disabled'       => $kconfig[KConfig::PROMETHEUS_INSECURE]->locked ?? false,
                 'ignore'         => $kconfig[KConfig::PROMETHEUS_INSECURE]->locked ?? false,
             ]