Skip to content

fix: frontend errors#173

Open
faelau wants to merge 2 commits intoIcinga:mainfrom
faelau:fix-frontend-errors
Open

fix: frontend errors#173
faelau wants to merge 2 commits intoIcinga:mainfrom
faelau:fix-frontend-errors

Conversation

@faelau
Copy link
Copy Markdown

@faelau faelau commented Apr 21, 2026

This PR fixes some error that provokes an error on various widgets if a service is in the state pending or has no parent.

Please feel free to edit the PR if the submitted code does not conform with your internal coding guidelines.

The typo provokes a failure if a service is in a pending state, so no
match is given
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 21, 2026

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @faelau

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@faelau faelau force-pushed the fix-frontend-errors branch from 4e16494 to 5bd7b85 Compare April 21, 2026 16:16
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 21, 2026

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @faelau

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

IcingaStateReasonRow can only use the HighlightDelta widget to render if
a parent exists. If there is no parent, it should just render the name
normally.
@faelau
Copy link
Copy Markdown
Author

faelau commented Apr 21, 2026

I've signed the Icinga CLA.

@bobapple
Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants