EventRuleConfigFormTest: Adapt to strict types in ipl

Mocks of `ipl\sql\Connection` and `ipl\orm\Query` must be adjusted
to match the new strict types in ipl.

The `Query::columns()` mocks previously returned an array, even though the
return type is supposed to be `static`.
This worked fine because the return value was only used in a `foreach`,
To match the `static` type the mocks now use `willReturnSelf` and mock
`Query::getIterator()`, so they can be foreached while being compatible
with ipl-orm.

The `Connection` some return values were added to match the return types
in ipl-sql, but they are unused and should have no effect on the test.

Author: BastianLedererIcinga

test/php/application/forms/EventRuleConfigFormTest.php

@@ -5,6 +5,7 @@
 
 namespace Tests\Icinga\Module\Notifications\Forms;
 
+use ArrayIterator;
 use DateTime;
 use Icinga\Module\Notifications\Forms\EventRuleConfigElements\ConfigProviderInterface;
 use Icinga\Module\Notifications\Forms\EventRuleConfigForm;
@@ -19,6 +20,7 @@
 use ipl\Orm\ResultSet;
 use ipl\Sql\Connection;
 use ipl\Web\Url;
+use PDOStatement;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ServerRequestInterface;
 
@@ -152,21 +154,27 @@ public function testLoadAndStorage(): void
         $firstRuleEscalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $firstRuleEscalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => 1,
                     'contact_id' => 1,
                     'contactgroup_id' => null,
                     'schedule_id' => null,
                     'channel_id' => 1
                 ])
-            ]);
+            ]));
 
         $secondRuleEscalationRecipientMock = $this->createMock(Query::class);
         $secondRuleEscalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $secondRuleEscalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => null,
                     'contact_id' => null,
@@ -181,7 +189,7 @@ public function testLoadAndStorage(): void
                     'schedule_id' => 1,
                     'channel_id' => 1
                 ])
-            ]);
+            ]));
 
         $ruleEscalationMock = $this->createMock(Query::class);
         $ruleEscalationMock->expects($this->once())
@@ -190,7 +198,7 @@ public function testLoadAndStorage(): void
             ->willReturnSelf();
 
         $queryResult = new ResultSet(
-            new \ArrayIterator([
+            new ArrayIterator([
                 (new RuleEscalation())->setProperties([
                     'id' => 1,
                     'condition' => null,
@@ -271,6 +279,8 @@ public function testLoadAndStorage(): void
                 } else {
                     $this->fail(sprintf('Unexpected table %s', $table));
                 }
+
+                return $this->createStub(PDOStatement::class);
             });
 
         $databaseMock->expects($this->once())
@@ -355,6 +365,8 @@ public function testLoadAndStorage(): void
                 } else {
                     $this->fail(sprintf('Unexpected table %s', $table));
                 }
+
+                return $this->createStub(PDOStatement::class);
             });
 
         $form = new EventRuleConfigForm($providerMock, $this->createStub(Url::class));
@@ -425,15 +437,18 @@ public function testNoChangesAlsoCauseNoUpdates(): void
         $escalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $escalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => 1,
                     'contact_id' => 1,
                     'contactgroup_id' => null,
                     'schedule_id' => null,
                     'channel_id' => 1
                 ])
-            ]);
+            ]));
 
         $ruleEscalationMock = $this->createMock(Query::class);
         $ruleEscalationMock->expects($this->once())
@@ -442,7 +457,7 @@ public function testNoChangesAlsoCauseNoUpdates(): void
             ->willReturnSelf();
 
         $queryResult = new ResultSet(
-            new \ArrayIterator([
+            new ArrayIterator([
                 (new RuleEscalation())->setProperties([
                     'id' => 1,
                     'condition' => null,
@@ -538,15 +553,18 @@ public function testIfARuleChangesOnlyTheRuleItselfIsUpdated(): void
         $escalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $escalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => 1,
                     'contact_id' => 1,
                     'contactgroup_id' => null,
                     'schedule_id' => null,
                     'channel_id' => 1
                 ])
-            ]);
+            ]));
 
         $ruleEscalationMock = $this->createMock(Query::class);
         $ruleEscalationMock->expects($this->once())
@@ -555,7 +573,7 @@ public function testIfARuleChangesOnlyTheRuleItselfIsUpdated(): void
             ->willReturnSelf();
 
         $queryResult = new ResultSet(
-            new \ArrayIterator([
+            new ArrayIterator([
                 (new RuleEscalation())->setProperties([
                     'id' => 1,
                     'condition' => null,
@@ -595,6 +613,8 @@ public function testIfARuleChangesOnlyTheRuleItselfIsUpdated(): void
                     ],
                     $data
                 );
+
+                return $this->createStub(PDOStatement::class);
             });
         $databaseMock->expects($this->never())
             ->method('insert');
@@ -667,15 +687,18 @@ public function testIfARuleChangesOnlyTheEscalationIsUpdated(): void
         $escalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $escalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => 1,
                     'contact_id' => 1,
                     'contactgroup_id' => null,
                     'schedule_id' => null,
                     'channel_id' => 1
                 ])
-            ]);
+            ]));
 
         $ruleEscalationMock = $this->createMock(Query::class);
         $ruleEscalationMock->expects($this->once())
@@ -684,7 +707,7 @@ public function testIfARuleChangesOnlyTheEscalationIsUpdated(): void
             ->willReturnSelf();
 
         $queryResult = new ResultSet(
-            new \ArrayIterator([
+            new ArrayIterator([
                 (new RuleEscalation())->setProperties([
                     'id' => 1,
                     'condition' => 'incident_severity>=crit&incident_age>5m',
@@ -727,6 +750,8 @@ public function testIfARuleChangesOnlyTheEscalationIsUpdated(): void
                     ],
                     $data
                 );
+
+                return $this->createStub(PDOStatement::class);
             });
         $databaseMock->expects($this->never())
             ->method('insert');
@@ -801,15 +826,18 @@ public function testIfARuleChangesOnlyTheEscalationRecipientIsUpdated(): void
         $escalationRecipientMock->expects($this->once())
             ->method('columns')
             ->with(['id', 'contact_id', 'contactgroup_id', 'schedule_id', 'channel_id'])
-            ->willReturn([
+            ->willReturnSelf();
+
+        $escalationRecipientMock->method('getIterator')
+            ->willReturn(new ArrayIterator([
                 (new RuleEscalationRecipient())->setProperties([
                     'id' => 1,
                     'contact_id' => null,
                     'contactgroup_id' => 1,
                     'schedule_id' => null,
                     'channel_id' => null
                 ])
-            ]);
+            ]));
 
         $ruleEscalationMock = $this->createMock(Query::class);
         $ruleEscalationMock->expects($this->once())
@@ -818,7 +846,7 @@ public function testIfARuleChangesOnlyTheEscalationRecipientIsUpdated(): void
             ->willReturnSelf();
 
         $queryResult = new ResultSet(
-            new \ArrayIterator([
+            new ArrayIterator([
                 (new RuleEscalation())->setProperties([
                     'id' => 1,
                     'condition' => null,
@@ -860,6 +888,8 @@ public function testIfARuleChangesOnlyTheEscalationRecipientIsUpdated(): void
                     ],
                     $data
                 );
+
+                return $this->createStub(PDOStatement::class);
             });
         $databaseMock->expects($this->never())
             ->method('insert');