schedule: Allow to duplicate the entire schedule

Author: nilmerg

application/controllers/ScheduleController.php

@@ -121,15 +121,22 @@ public function settingsAction(): void
         $form->setShowRemoveButton();
         $form->setSchedule($schedule);
         $form->setSubmitLabel($this->translate('Save Changes'));
-        $form->setAction($this->getRequest()->getUrl()->getAbsoluteUrl());
-        $form->on(Form::ON_SUBMIT, function ($form) use ($scheduleId) {
+        $form->setAction($this->getRequest()->getUrl()->setParam('showCompact')->getAbsoluteUrl());
+        $form->on(Form::ON_SUBMIT, function (ScheduleForm $form) {
             $schedule = $form->getSchedule();
-            Database::get()->transaction(function (Connection $db) use ($schedule) {
-                (new ScheduleRepository($db))->update($schedule);
-            });
+
+            if ($form->hasBeenDuplicated()) {
+                Database::get()->transaction(function (Connection $db) use ($schedule) {
+                    (new ScheduleRepository($db))->duplicate($schedule);
+                });
+            } else {
+                Database::get()->transaction(function (Connection $db) use ($schedule) {
+                    (new ScheduleRepository($db))->update($schedule);
+                });
+            }
 
             $this->sendExtraUpdates(['#col1']);
-            $this->redirectNow(Links::schedule($scheduleId));
+            $this->redirectNow(Links::schedule($schedule->id));
         });
         $form->on(Form::ON_SENT, function (ScheduleForm $form) use ($scheduleId) {
             if ($form->hasBeenRemoved()) {

application/forms/ScheduleForm.php

@@ -7,13 +7,15 @@
 
 use DateTime;
 use DateTimeZone;
+use Icinga\Module\Notifications\Common\Database;
 use Icinga\Module\Notifications\Model\Schedule;
 use Icinga\Web\Session;
 use IntlTimeZone;
 use ipl\Html\Attributes;
 use ipl\Html\HtmlDocument;
 use ipl\Html\HtmlElement;
 use ipl\Html\Text;
+use ipl\Stdlib\Filter;
 use ipl\Validator\CallbackValidator;
 use ipl\Web\Common\CsrfCounterMeasure;
 use ipl\Web\Compat\CompatForm;
@@ -73,6 +75,16 @@ public function hasBeenRemoved(): bool
         return $csrf !== null && $csrf->isValid() && $btn !== null && $btn->getName() === 'delete';
     }
 
+    /**
+     * Get whether the duplicate button was pressed
+     *
+     * @return bool
+     */
+    public function hasBeenDuplicated(): bool
+    {
+        return $this->getPressedSubmitElement()?->getName() === 'duplicate';
+    }
+
     public function __construct()
     {
         $this->schedule = new Schedule();
@@ -120,7 +132,25 @@ protected function assemble(): void
         $this->addElement('text', 'name', [
             'required'      => true,
             'label'         => $this->translate('Schedule Name'),
-            'placeholder'   => $this->translate('e.g. working hours, on call, etc ...')
+            'placeholder'   => $this->translate('e.g. working hours, on call, etc ...'),
+            'validators'    => [
+                new CallbackValidator(function ($value, $validator) {
+                    $schedules = Schedule::on(Database::get())
+                        ->columns('id')
+                        ->filter(Filter::equal('name', $value));
+                    if (! $this->hasBeenDuplicated()) {
+                        $schedules->filter(Filter::unequal('id', $this->schedule->id));
+                    }
+
+                    if ($schedules->first() !== null) {
+                        $validator->addMessage($this->translate('A rotation with this name already exists'));
+
+                        return false;
+                    }
+
+                    return true;
+                })
+            ]
         ]);
 
         if ($this->showTimezoneSuggestionInput) {
@@ -165,17 +195,25 @@ protected function assemble(): void
             'label' => $this->getSubmitLabel()
         ]);
 
+        $additionalButtons = [];
         if ($this->showRemoveButton) {
             $removeBtn = $this->createElement('submit', 'delete', [
                 'label' => $this->translate('Delete'),
                 'class' => 'btn-remove',
                 'formnovalidate' => true
             ]);
             $this->registerElement($removeBtn);
-
-            $this->getElement('submit')->prependWrapper((new HtmlDocument())->setHtmlContent($removeBtn));
+            $additionalButtons[] = $removeBtn;
         }
 
+        $duplicateBtn = $this->createElement('submit', 'duplicate', [
+            'label' => $this->translate('Duplicate')
+        ]);
+        $this->registerElement($duplicateBtn);
+        $additionalButtons[] = $duplicateBtn;
+
+        $this->getElement('submit')->prependWrapper((new HtmlDocument())->setHtmlContent(...$additionalButtons));
+
         $this->addCsrfCounterMeasure(Session::getSession()->getId());
     }
 
@@ -203,4 +241,9 @@ private function hasChanges(): bool
 
         return $values !== $storedValues;
     }
+
+    public function hasBeenSubmitted()
+    {
+        return parent::hasBeenSubmitted() || ($this->hasBeenSent() && $this->hasBeenDuplicated());
+    }
 }