Skip to content

Commit 8af210d

Browse files
Ensure compatibility with RewriteFilterBehavior
Add types and return statements to esnure compatibility with RewriteFilterbehavior of the modernized ipl-orm.
1 parent fc1c5db commit 8af210d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

library/Notifications/Model/Behavior/IcingaCustomVars.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function rewriteColumnDefinition(ColumnDefinition $def, string $relation)
5353
));
5454
}
5555

56-
public function rewriteCondition(Filter\Condition $condition, $relation = null)
56+
public function rewriteCondition(Filter\Condition $condition, ?string $relation = null): ?Filter\Condition
5757
{
5858
if (! $this->isSelectableColumn($condition->metaData()->get('columnName', ''))) {
5959
return null;

library/Notifications/Model/Behavior/IdTagAggregator.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ public function rewriteColumnDefinition(ColumnDefinition $def, string $relation)
9393
{
9494
}
9595

96-
public function rewriteCondition(Filter\Condition $condition, $relation = null)
96+
public function rewriteCondition(Filter\Condition $condition, $relation = null): null
9797
{
98+
return null;
9899
}
99100
}

0 commit comments

Comments
 (0)