Add error if decode fails

Author: jrauh01

application/forms/ChannelForm.php

@@ -6,14 +6,16 @@
 
 use DateTime;
 use Icinga\Exception\Http\HttpNotFoundException;
-use Icinga\Module\Notifications\Model\Channel;
 use Icinga\Module\Notifications\Model\AvailableChannelType;
+use Icinga\Module\Notifications\Model\Channel;
 use Icinga\Module\Notifications\Model\Contact;
 use Icinga\Module\Notifications\Model\RuleEscalationRecipient;
 use Icinga\Web\Session;
+use ipl\Html\Attributes;
 use ipl\Html\Contract\FormSubmitElement;
 use ipl\Html\FormElement\BaseFormElement;
 use ipl\Html\FormElement\FieldsetElement;
+use ipl\Html\HtmlElement;
 use ipl\I18n\GettextTranslator;
 use ipl\I18n\StaticTranslator;
 use ipl\Sql\Connection;
@@ -267,6 +269,24 @@ protected function createConfigElements(string $type, string $config): void
         $elementsConfig = json_decode($config, true);
 
         if (empty($elementsConfig)) {
+            $this->prependHtml(
+                HtmlElement::create(
+                    'ul',
+                    Attributes::create(['class' => 'errors']),
+                    HtmlElement::create(
+                        'li',
+                        null,
+                        sprintf(
+                            $this->translate(
+                                'Could not decode options for type \'%s\'.'
+                                . ' Check if your database\'s character set is correctly configured.'
+                            ),
+                            $type
+                        )
+                    )
+                )
+            );
+
             return;
         }
 
@@ -449,4 +469,20 @@ private function fetchDbValues(): array
             'config'    => json_decode($channel->config, true) ?? []
         ];
     }
+
+    /**
+     * Validate all elements
+     *
+     * @return $this
+     */
+    public function validate(): self
+    {
+        parent::validate();
+
+        if (! $this->hasElement('config')) {
+            $this->isValid = false;
+        }
+
+        return $this;
+    }
 }