Skip to content

ObjectsRendererHook: Always use _next as data-base-target#323

Merged
sukhwinder33445 merged 1 commit into
mainfrom
fix/object-link-base-target
Apr 30, 2025
Merged

ObjectsRendererHook: Always use _next as data-base-target#323
sukhwinder33445 merged 1 commit into
mainfrom
fix/object-link-base-target

Conversation

@sukhwinder33445

Copy link
Copy Markdown
Contributor

Otherwise, the link is opened in the same container (_self).

@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Apr 17, 2025
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg April 17, 2025 14:50
@sukhwinder33445 sukhwinder33445 self-assigned this Apr 17, 2025
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Apr 17, 2025

@raviks789 raviks789 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas rebase onto main branch.

Otherwise the link is opened in the same container (_self).
@sukhwinder33445 sukhwinder33445 force-pushed the fix/object-link-base-target branch from 47c1cd1 to 81088f6 Compare April 29, 2025 13:51
@sukhwinder33445 sukhwinder33445 merged commit ef04351 into main Apr 30, 2025
@sukhwinder33445 sukhwinder33445 deleted the fix/object-link-base-target branch April 30, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants