Skip to content

Highlight sidebar entries on result hover#360

Merged
nilmerg merged 2 commits into
mainfrom
highlight-sidebar-entries-on-result-hover
Nov 5, 2025
Merged

Highlight sidebar entries on result hover#360
nilmerg merged 2 commits into
mainfrom
highlight-sidebar-entries-on-result-hover

Conversation

@nilmerg
Copy link
Copy Markdown
Member

@nilmerg nilmerg commented Oct 7, 2025

Originally part of #305

@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Oct 7, 2025
@sukhwinder33445 sukhwinder33445 force-pushed the highlight-sidebar-entries-on-result-hover branch from 4496d8e to c21291f Compare October 29, 2025 11:02
@sukhwinder33445 sukhwinder33445 self-assigned this Oct 29, 2025
@sukhwinder33445
Copy link
Copy Markdown
Contributor

This looks ready to merge. @nilmerg , could you please have a look?

@nilmerg
Copy link
Copy Markdown
Member Author

nilmerg commented Nov 4, 2025

Please rebase. Oh and please refactor this a bit, it's fine that you wanted to de-duplicate code, but handleEntryHover is just lame. Implement identifyRelatedEntries(entry) instead.

@sukhwinder33445 sukhwinder33445 force-pushed the highlight-sidebar-entries-on-result-hover branch 3 times, most recently from 5aacd27 to 96147a3 Compare November 4, 2025 14:03
@sukhwinder33445 sukhwinder33445 force-pushed the highlight-sidebar-entries-on-result-hover branch from 96147a3 to 6d2d920 Compare November 4, 2025 14:09
@sukhwinder33445
Copy link
Copy Markdown
Contributor

Done.

Comment thread public/js/schedule.js
@sukhwinder33445 sukhwinder33445 force-pushed the highlight-sidebar-entries-on-result-hover branch from 6d2d920 to d6fc22c Compare November 5, 2025 15:10
@nilmerg nilmerg merged commit 8f9f448 into main Nov 5, 2025
10 checks passed
@nilmerg nilmerg deleted the highlight-sidebar-entries-on-result-hover branch November 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants