Skip to content

Highlight sidebar entries on result hover #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilmerg merged 2 commits into from
Nov 5, 2025
Merged

Highlight sidebar entries on result hover #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af31f28
Highlight related sidebar row when result `.entry` is hovered
sukhwinder33445 Mar 31, 2025
d6fc22c
schedule.js: Optimize duplicate code and add JSDoc
sukhwinder33445 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions public/css/schedule.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,22 @@

/* Design */

.schedule-detail .entry.highlighted {
outline: 2px solid var(--entry-border-color);
outline-offset: 1px;
}
.schedule-detail {
.entry.highlighted {
outline: 2px solid var(--entry-border-color);
outline-offset: 1px;
}

.schedule-detail .step.highlighted {
background-color: @gray-lighter;
border-color: @gray-light;
.sidebar .row-title.highlighted,
.step.highlighted {
background-color: @gray-lighter;
border-color: @gray-light;
}

.sidebar .row-title.highlighted {
margin-top: -1px; // cover the border-top area
padding-top: 1px;
}
}

.schedule-detail .from-scratch-hint {
Expand Down
83 changes: 52 additions & 31 deletions public/js/schedule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
this.on('mouseleave', '#notifications-schedule .entry', this.onEntryLeave, this);
}

/**
* Make the sidebar sortable and add drag&drop support.
*
* @param event The event object.
*/
onRendered(event)
{
if (event.target !== event.currentTarget) {
Expand All @@ -46,6 +51,11 @@
});
}

/**
* Handle drop event on the sidebar.
*
* @param event The event object.
*/
onDrop(event)
{
event = event.originalEvent;
Expand Down Expand Up @@ -74,29 +84,19 @@
form.requestSubmit();
}

/**
* Handle hover (`mouseenter`) event on schedule entries.
*
* @param event The mouse event object.
*/
onEntryHover(event)
{
const entry = event.currentTarget;
const overlay = entry.parentElement;
const grid = overlay.previousSibling;
const [relatedEntries, tooltip] = event.data.self.identifyRelatedEntries(event);

let relatedElements;
if ('rotationPosition' in entry.dataset) {
relatedElements = grid.querySelectorAll(
'[data-y-position="' + entry.dataset.rotationPosition + '"]'
);
} else {
relatedElements = overlay.querySelectorAll(
'[data-rotation-position="' + entry.dataset.entryPosition + '"]'
);
}

relatedElements.forEach((relatedElement) => {
relatedElement.classList.add('highlighted');
});
relatedEntries.forEach(element => element.classList.add('highlighted'));

const tooltip = entry.querySelector('.rotation-info');
if (tooltip) {
const grid = event.currentTarget.parentElement.previousSibling;
requestAnimationFrame(() => {
const tooltipRect = tooltip.getBoundingClientRect();
const gridRect = grid.getBoundingClientRect();
Expand All @@ -111,31 +111,52 @@
}
}

/**
* Handle hover (`mouseleave`) event on schedule entries.
*
* @param event The mouse event object.
*/
onEntryLeave(event)
{
const [relatedEntries, tooltip] = event.data.self.identifyRelatedEntries(event);

relatedEntries.forEach(element => element.classList.remove('highlighted'));

if (tooltip) {
tooltip.classList.remove('is-left', 'is-bottom');
}
}

/**
* Identify hover-related entries.
*
* @param event The mouse event object.
*
* @returns {[HTMLElement[]|NodeListOf<HTMLElement>, HTMLElement|null]}
Comment thread
BastianLedererIcinga marked this conversation as resolved.
*/
identifyRelatedEntries(event) {
const entry = event.currentTarget;
const overlay = entry.parentElement;
const grid = overlay.previousSibling;
const sideBar = grid.previousSibling;

let relatedElements;
let relatedEntries;
if ('rotationPosition' in entry.dataset) {
relatedElements = grid.querySelectorAll(
'[data-y-position="' + entry.dataset.rotationPosition + '"]'
relatedEntries = Array.from(
grid.querySelectorAll('[data-y-position="' + entry.dataset.rotationPosition + '"]')
);

relatedEntries.push(sideBar.childNodes[Number(entry.dataset.rotationPosition)]);
} else {
relatedElements = overlay.querySelectorAll(
relatedEntries = overlay.querySelectorAll(
'[data-rotation-position="' + entry.dataset.entryPosition + '"]'
);
)
}

relatedElements.forEach((relatedElement) => {
relatedElement.classList.remove('highlighted');
});

const tooltip = entry.querySelector('.rotation-info');
if (tooltip) {
tooltip.classList.remove('is-left', 'is-bottom');
}
return [
relatedEntries,
entry.querySelector('.rotation-info')
];
}
}

Expand Down
Loading