Modernize code#448
Merged
Merged
Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
8af210d to
6da5a42
Compare
sukhwinder33445
requested changes
Mar 4, 2026
| } | ||
|
|
||
| public function rewriteCondition(Filter\Condition $condition, $relation = null) | ||
| public function rewriteCondition(Filter\Condition $condition, $relation = null): null |
Contributor
There was a problem hiding this comment.
Please add type for $relation param (?string $relation = null).
Member
|
Have you overseen #403? |
Contributor
Author
Yes... |
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
4b5d696 to
b23b742
Compare
- Remove obsolete workflow trigger for `release/*` branch pushes - Run workflow on push to branch `support/*`
Use defaults from new workflows.
Allow GitHub Actions to run for every pull request instead of only main-based pull requests
It is used as DataProvider in unit-tests and `>=phpUnit10` requires it to be static. ref https://docs.phpunit.de/en/10.5/writing-tests-for-phpunit.html#data-providers
PHP 8.4 deprecates implicitly nullable parameter declarations, meaning that declaring a function or method parameter with a default value of `null` without explicitly marking the type as nullable (using `?Type`) will trigger a deprecation notice: https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter
`PDO::MYSQL_ATTR_INIT_COMMAND` is deprecated as of PHP 8.5 and should be replaced with `Pdo\Mysql::ATTR_INIT_COMMAND`: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.pdo
`SplObjectStorage` methods `attach()`, `contains()`, and `detach()` are deprecated in PHP 8.5. Since these methods are aliases for the methods `offsetSet()`, `offsetExists()` and `offsetUnset()` of the `ArrayAccess` interface implemented by `SplObjectStorage`, they can safely be replaced by these equivalents: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.spl
In PHP 8.5, `null` can no longer be used as an array key. Previously, `null` was automatically converted to an empty string (`''`), but this behavior is now deprecated: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.core.using-null-as-an-array-offset
The package has been migrated to `reac/async`. Use that instead.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
b23b742 to
43ed82c
Compare
BastianLedererIcinga
changed the base branch from
main
to
use-typed-class-attributes
Set the return type to static to ensure compatibility with ipl-orm.
Add types and return statements to ensure compatibility with `RewriteFilterbehavior` of ipl-orm.
Add parameter and return type for compatibility with ipl-html and ipl-stdlib
Add types and missing return statements for compatibility with ipl-orm.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
43ed82c to
069e978
Compare
BastianLedererIcinga
merged commit cfa7368
into
use-typed-class-attributes
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add types and missing return statements for implementations of:
QueryAwarebehaviorRewriteFilterbehaviorTo ensure compatibility with Icinga/ipl-orm#155.
Add types to
ContactForm::isValidEent()as required by Icinga/ipl-stdlib#68