Support configuration of event rules for generic sources#471
Open
BastianLedererIcinga wants to merge 5 commits into
Open
Support configuration of event rules for generic sources#471BastianLedererIcinga wants to merge 5 commits into
BastianLedererIcinga wants to merge 5 commits into
Conversation
`RuleSerializer` serializes rules as json `RuleParser` can read them and create an ipl `Filter\Ŗule` from it
Introduce a new version of the `SourceHook` interface for v 1.0
Use the functions of the new `SourceHook` interface, the `RuleParser` and `RuleSerializer` to set up the filter editor of an event rule-
Adjust `resolveSourceHook` to return `null` for generic sources without integration. Adjust `searchEditorAction` to create a simple editor without validation, enrichment and suggestions for these sources and save the filter as a querystring.
BastianLedererIcinga
force-pushed
the
configure-rules-without-integration
branch
from
457f0fa to
889baa6
Compare
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
from
3a0fa1e to
015bfb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For event rules of generic sources a simple
SearchEditorwithout enrichment, validation and suggestions is created.resolve #450