Add write support for models#482
Open
BastianLedererIcinga wants to merge 63 commits into
Open
Conversation
BastianLedererIcinga
force-pushed
the
add-write-support
branch
2 times, most recently
from
56b1dff to
1bbda5e
Compare
BastianLedererIcinga
force-pushed
the
add-write-support
branch
3 times, most recently
from
71222a7 to
6ce89fd
Compare
Contributor
Author
|
@sukhwinder33445 As discussed the |
| * | ||
| * @return $this | ||
| */ | ||
| public function markDeleted(): static |
Contributor
Author
There was a problem hiding this comment.
I think it makes sense to rename this to delete(), but that requires a rename of the existing Model\Rotation::delete(), which I wanted to avoid until we agreed that the function is in the right place here.
sukhwinder33445
left a comment
sukhwinder33445
left a comment
Contributor
There was a problem hiding this comment.
Once this is done, I’ll review it further, as it may require changes to other methods.
sukhwinder33445
requested changes
Jun 24, 2026
sukhwinder33445
previously approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support modifying models and then persisting them to the DB, an
EntityManageris added, which can save and delete any givenModel.To support this a new
Modelclass is added that serves as parent class for all models in the module, it tracks whether it already exists in the DB, and if what columns have been modified.Calling
onon such a model returns aStatefulQuery, which sets theisNewflag to false on all yielded models, so their state tracking works.