Allow to duplicate configuration#494
Draft
nilmerg wants to merge 15 commits into
Draft
Conversation
nilmerg
force-pushed
the
feature/duplicate-configuration-158
branch
6 times, most recently
from
eba21b6 to
e9356db
Compare
nilmerg
force-pushed
the
feature/duplicate-configuration-158
branch
from
e9356db to
ee331b7
Compare
Verify the statements the repository issues against a mocked database connection, serving the ORM queries it builds internally by returning SQLite-backed PDOStatements the ORM hydrates into models. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Verify the recurrence rules and shift durations produced for every mode (24-7, partial, multi) and their option branches, plus unknown-mode handling and JSON-encoded options. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copied over from `RotationConfigForm`
Copied over from `RotationConfigForm`
nilmerg
force-pushed
the
feature/duplicate-configuration-158
branch
from
ee331b7 to
7ace1dd
Compare
Verify that moving a rotation frees up its current priority, shifts the in-between siblings in the right direction and finally places it at the new priority. Also handles moving to the same priority. The shared statement helper now defaults to `PDO::FETCH_OBJ` (as the module's connection does), which `move()` relies on; the ORM paths override it to `PDO::FETCH_ASSOC` themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e/duplicate Verify the statements `ScheduleRepository` issues against a mocked database connection, serving the ORM queries it builds internally by returning SQLite-backed PDOStatements the ORM hydrates into models. Rotation deletion/duplication is delegated to and covered by `RotationRepositoryTest`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nilmerg
force-pushed
the
feature/duplicate-configuration-158
branch
from
7ace1dd to
07ca7d3
Compare
Verify the statements `ContactRepository` issues against a mocked database connection, serving the ORM queries it builds internally by returning SQLite-backed PDOStatements the ORM hydrates into models. Covers the differential address update and the escalation cleanup on deletion; rotation handling is delegated to and covered by `RotationRepositoryTest`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nilmerg
force-pushed
the
feature/duplicate-configuration-158
branch
from
07ca7d3 to
dbbefdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #158