EntityManager: Quote all identifiers#514
Merged
Merged
Conversation
Call `Connection::quoteIdentifier()` on all used identifiers, to avoid SQL errors when a reserved keyword is used as column/table name. The test model `Pairing` is adjusted to use several keywords so the tests cover this, the `RecordingConnection` unquotes identifiers when writing to its `calls` array, so assertions can still use the plain identifiers.
nilmerg
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EntityManagermust quote identifiers, to allow writing to columns likerule_escalation.condition, which currently fails on MySql.Call
Connection::quoteIdentifier()on all used identifiers, to avoid SQL errors when a reserved keyword is used as column/table name.The test model
Pairingis adjusted to use several keywords so the tests cover this, theRecordingConnectionunquotes identifiers when writing to itscallsarray, so assertions can still use the plain identifiers.