Decouple incident rendering from source integrations#515
Open
sukhwinder33445 wants to merge 6 commits into
Open
Decouple incident rendering from source integrations#515sukhwinder33445 wants to merge 6 commits into
sukhwinder33445 wants to merge 6 commits into
Conversation
sukhwinder33445
force-pushed
the
decouple-incident-rendering-from-source-integrations
branch
from
July 17, 2026 13:54
df92f2e to
4bb17bb
Compare
sukhwinder33445
force-pushed
the
decouple-incident-rendering-from-source-integrations
branch
4 times, most recently
from
July 20, 2026 07:16
27cc4f8 to
893671d
Compare
sukhwinder33445
force-pushed
the
decouple-incident-rendering-from-source-integrations
branch
from
July 20, 2026 07:25
893671d to
900c04e
Compare
- Drop class `ObjectsRenderer` - Replace `ObjectRendererHook::createObjectLink()` with `SourceHook::createObjectLink()` - Use the existing db column `object.name` for object name.
The message is limited to `1k` chars for list items and `10k` in detail view.
Persist the collapse state for all incidents that the user chooses.
sukhwinder33445
force-pushed
the
decouple-incident-rendering-from-source-integrations
branch
from
July 20, 2026 07:31
900c04e to
2253cfe
Compare
sukhwinder33445
force-pushed
the
decouple-incident-rendering-from-source-integrations
branch
from
July 20, 2026 07:39
2253cfe to
5a34275
Compare
- Remove obsolete `view-mode-switcher.less`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Show
incident.messageas the caption in the incidents list (truncated to 1k chars) and in a new, collapsible, copyable "Message" section in the incident detail view (truncated to a configurable limit, default 10k, via the newincident_message_character_limitsetting inconfig.ini)Deprecate
ObjectsRendererHookand remove its implementation (ObjectsRenderer); object names now come directly from theobject.namecolumn, and object links are built viaSourceHook::createObjectLink()(or a fallback link toobject.url)Persist the collapse state (across all incidents) for the new
Messagesection.Add
ViewModeSwitcherfor incident list once AddViewModeSwitchercontrol ipl-web#392 is merged.resolves #493