Skip to content

Commit 53c258d

Browse files
committed
Revert "GitHub Actions: Use preinstalled dependencies on Windows"
This reverts commit 8e766a6, to fix our Windows GitHub actions.
1 parent f63bbec commit 53c258d

2 files changed

Lines changed: 38 additions & 22 deletions

File tree

doc/win-dev.ps1

Lines changed: 37 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -70,26 +70,43 @@ try {
7070
$Env:Path += $ChocoPath
7171
}
7272

73-
# GitHub Actions uses an image that comes with most dependencies preinstalled. Don't install them twice.
74-
if (-not $Env:GITHUB_ACTIONS) {
75-
choco install -y `
76-
"visualstudio${VsVersion}community" `
77-
"visualstudio${VsVersion}-workload-vctools" `
78-
"visualstudio${VsVersion}-workload-manageddesktop" `
79-
"visualstudio${VsVersion}-workload-nativedesktop" `
80-
"visualstudio${VsVersion}-workload-universal" `
81-
"visualstudio${VsVersion}buildtools" `
82-
git `
83-
cmake `
84-
winflexbison3 `
85-
netfx-4.6-devpack `
86-
windows-sdk-8.1 `
87-
wixtoolset
88-
ThrowOnNativeFailure
89-
} else {
90-
choco install -y winflexbison3
91-
ThrowOnNativeFailure
92-
}
73+
74+
choco install -y "visualstudio${VsVersion}community"
75+
ThrowOnNativeFailure
76+
77+
choco install -y "visualstudio${VsVersion}-workload-vctools"
78+
ThrowOnNativeFailure
79+
80+
choco install -y "visualstudio${VsVersion}-workload-manageddesktop"
81+
ThrowOnNativeFailure
82+
83+
choco install -y "visualstudio${VsVersion}-workload-nativedesktop"
84+
ThrowOnNativeFailure
85+
86+
choco install -y "visualstudio${VsVersion}-workload-universal"
87+
ThrowOnNativeFailure
88+
89+
choco install -y "visualstudio${VsVersion}buildtools"
90+
ThrowOnNativeFailure
91+
92+
93+
choco install -y git
94+
ThrowOnNativeFailure
95+
96+
choco install -y cmake
97+
ThrowOnNativeFailure
98+
99+
choco install -y netfx-4.6-devpack
100+
ThrowOnNativeFailure
101+
102+
choco install -y winflexbison3
103+
ThrowOnNativeFailure
104+
105+
choco install -y windows-sdk-8.1
106+
ThrowOnNativeFailure
107+
108+
choco install -y wixtoolset
109+
ThrowOnNativeFailure
93110

94111
# Disable the progress bar for downloads from the Web, which will speed up the entire download process
95112
$Global:ProgressPreference = 'SilentlyContinue';

tools/win32/load-vsenv.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ if (Test-Path env:BITS) {
2929

3030
# Execute vcvars in cmd and store env
3131
$vcvars_locations = @(
32-
"${VSBASE}\BuildTools\VC\Auxiliary\Build\vcvars${bits}.bat"
32+
"${VSBASE}\BuildTools\VC\Auxiliary\Build\vcvars${bits}.bat",
3333
"${VSBASE}\Community\VC\Auxiliary\Build\vcvars${bits}.bat"
34-
"${VSBASE}\Enterprise\VC\Auxiliary\Build\vcvars${bits}.bat"
3534
)
3635

3736
$vcvars = $null

0 commit comments

Comments
 (0)