Checkable: Extract parents directly from dependency groups

Author: yhabteab

lib/icinga/checkable-dependency.cpp

@@ -248,12 +248,8 @@ bool Checkable::AffectsChildren(const CheckResult::Ptr& cr) const
 std::set<Checkable::Ptr> Checkable::GetParents() const
 {
 	std::set<Checkable::Ptr> parents;
-
-	for (const Dependency::Ptr& dep : GetDependencies()) {
-		Checkable::Ptr parent = dep->GetParent();
-
-		if (parent && parent.get() != this)
-			parents.insert(parent);
+	for (auto& dependencyGroup : GetDependencyGroups()) {
+		dependencyGroup->LoadParents(parents);
 	}
 
 	return parents;

lib/icinga/dependency-group.cpp

@@ -146,6 +146,20 @@ std::vector<Dependency::Ptr> DependencyGroup::GetDependenciesForChild(const Chec
 	return dependencies;
 }
 
+/**
+ * Load all parent Checkables of the current dependency group.
+ *
+ * @param parents The set to load the parent Checkables into.
+ */
+void DependencyGroup::LoadParents(std::set<Checkable::Ptr>& parents) const
+{
+    std::lock_guard lock(m_Mutex);
+    for (auto& [compositeKey, children] : m_Members) {
+		ASSERT(!children.empty()); // We should never have an empty map for any given key at any given time.
+    	parents.insert(std::get<0>(compositeKey));
+    }
+}
+
 /**
  * Retrieve the number of dependency objects in the current dependency group.
  *

lib/icinga/dependency.hpp

@@ -148,6 +148,7 @@ class DependencyGroup final : public SharedObject
 	void AddDependency(const Dependency::Ptr& dependency);
 	void RemoveDependency(const Dependency::Ptr& dependency);
 	std::vector<Dependency::Ptr> GetDependenciesForChild(const Checkable* child) const;
+	void LoadParents(std::set<Checkable::Ptr>& parents) const;
 	size_t GetDependenciesCount() const;
 
 	void SetIcingaDBIdentifier(const String& identifier);