Add flush_threshold and flush_interval to remaining perfdata writers#10834
Draft
jschmidt-icinga wants to merge 3 commits into
Draft
Add flush_threshold and flush_interval to remaining perfdata writers#10834jschmidt-icinga wants to merge 3 commits into
flush_threshold and flush_interval to remaining perfdata writers#10834jschmidt-icinga wants to merge 3 commits into
Conversation
jschmidt-icinga
force-pushed
the
perfdata-add-flush-thresholds
branch
2 times, most recently
from
b86f6cf to
e52320f
Compare
jschmidt-icinga
force-pushed
the
perfdata-add-flush-thresholds
branch
from
e52320f to
f2f0614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
flush_thresholdandflush_intervaloptions to remaining perfdata-writers, i.e.GraphiteWriter,GelfWriter, andOpenTsdbWriter. This should solve most of the performance degradation since #10668, because the overhead for one coroutine spawn per 2MiB/15s of perfdata should be negligible.This was made as a shot-in-the-dark fix for #10825, but it would still be worthwhile for the performance improvements. I'll do a few benchmarks before we consider merging this. Maybe I'll also add a commit that reuses the coroutine in
PerfdataWriterConnection, if that also yields some improvements, and make this a general perfdata performance PR.