Commit b7da98f
authored
Fix
#1046 introduced two problems
to the `SearchControls` trait.
Returning `false` from `SearchControls::callHandleRequest()` prevents
the ipl-web `SearchControls` trait from calling `handleRequest()` in
both `createSearchBar()` and `createSearchEditor()`.
An implementation of `createSearchEditor()` is added, which explicitly
calls `$editor->handleRequest()` as `createSearchBar()` already does.
Without this no `SearchEditor` in the entire module is usable.
An other problem is that moving the call of
`$searchbar->handleRequest()` also delayed its `assemble()`, so this if
block was entered before the assemble, resulting in the wrapper being
added twice.
```
if (($wrapper = $searchBar->getWrapper()) && ! $wrapper->getWrapper()) {
// TODO: Remove this once ipl-web v0.7.0 is required
$searchBar->addWrapper(Html::tag('div', ['class' => 'search-controls']));
}
```
which caused a visual bug:
<img width="447" height="175" alt="Screenshot from 2026-06-25 11-01-42"
src="https://github.com/user-attachments/assets/4e852585-c677-4c70-8f95-631601294de4"
/>
The statement should be safe to remove together with the less that has
the same `TODO`.SearchControls trait (#1388)2 files changed
Lines changed: 16 additions & 52 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
| |||
51 | 47 | | |
52 | 48 | | |
53 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
54 | 64 | | |
55 | 65 | | |
56 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | 110 | | |
157 | 111 | | |
158 | 112 | | |
| |||
0 commit comments