Move the HostController::joinFix() method to DependencyNode

[sukhwinder33445]

No description provided.

[nilmerg]

Is it possible to use the new method in ObjectDetail as well? Then please do so.

[sukhwinder33445]

Is it possible to use the new method in ObjectDetail as well? Then please do so.

The ObjectDetail::createAffectedObjects() only fetch failed edges.

[Copilot]

Pull Request Overview

This PR moves the host-specific join workaround from HostController into a new DependencyNode::forHost() static method and cleans up the controller accordingly.

• Adds forHost() to DependencyNode to encapsulate the host‐filter logic
• Updates HostController::fetchDependencyNodes() to use forHost() and removes joinFix()
• Removes unused imports and the old joinFix() method from HostController

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
library/Icingadb/Model/DependencyNode.php	Added forHost() method with EXISTS filter to handle bug in ipl-orm
application/controllers/HostController.php	Updated fetchDependencyNodes() to call forHost() and removed joinFix() plus unused imports

Comments suppressed due to low confidence (3)

library/Icingadb/Model/DependencyNode.php:137

• Add an @return Query annotation to the docblock of forHost() to clarify the method’s return type.

    /**

library/Icingadb/Model/DependencyNode.php:149

• Consider adding unit tests for forHost() to verify correct filtering of parents vs. children and to prevent regressions once the underlying ipl-orm issue is fixed.

    public static function forHost(string $hostId, Connection $db, bool $fetchParents = false): Query

library/Icingadb/Model/DependencyNode.php:149

• [nitpick] The method name forHost is a bit vague; consider renaming to something like filterByHost or queryForHost to better convey that this returns a query scoped to a host.

    public static function forHost(string $hostId, Connection $db, bool $fetchParents = false): Query