Skip to content

Auth: Apply filter/hosts and filter/services to dependency queries#1247

Merged
nilmerg merged 1 commit into
mainfrom
fix/ensure-host-and-service-restrictions-apply-to-dependencies
Jul 14, 2025
Merged

Auth: Apply filter/hosts and filter/services to dependency queries#1247
nilmerg merged 1 commit into
mainfrom
fix/ensure-host-and-service-restrictions-apply-to-dependencies

Conversation

@nilmerg
Copy link
Copy Markdown
Member

@nilmerg nilmerg commented Jul 10, 2025

refs #1242

@nilmerg nilmerg added this to the 1.2.2 milestone Jul 10, 2025
@nilmerg nilmerg requested a review from sukhwinder33445 July 10, 2025 08:01
@nilmerg nilmerg self-assigned this Jul 10, 2025
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Jul 10, 2025
@nilmerg nilmerg force-pushed the fix/ensure-host-and-service-restrictions-apply-to-dependencies branch from bfa1306 to 60d38fe Compare July 10, 2025 11:13
sukhwinder33445
sukhwinder33445 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

sukhwinder33445
sukhwinder33445 requested changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sukhwinder33445 sukhwinder33445 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 180 also requires the fix for filter/objects restriction.

Nope, ignore this please, the condition already has $customVarRelationName = false.

@sukhwinder33445 sukhwinder33445 self-requested a review July 10, 2025 15:41
@sukhwinder33445 sukhwinder33445 mentioned this pull request Jul 11, 2025
Closed
@nilmerg nilmerg merged commit 9386931 into main Jul 14, 2025
10 checks passed
@nilmerg nilmerg deleted the fix/ensure-host-and-service-restrictions-apply-to-dependencies branch July 14, 2025 13:49
@nilmerg nilmerg added bug Something isn't working area/access-control Affects the authorization of users labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

Assignees

@nilmerg nilmerg

Labels

area/access-control Affects the authorization of users bug Something isn't working cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

1.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@nilmerg @sukhwinder33445