Fix SearchControls trait#1388
Merged
Merged
Conversation
`callHandleRequest()` returning false prevents the ipl-web trait from calling `handleRequest` for both the created `SearchBar` and `SearchEditor`. `createSearchBar()` already calls it explicitly, the same must be done in `createSearchEditor()`, to create a functional `SearchEditor`.
17e8498 moved the call of `$searchBar->handleRequest()` and the subsequent call of `assemble()` after an if satement, which served the purpose of adding a missing `.search-controls` wrapper for ipl-web < 0.7.0. Since `SearchBar::assemble` is responsible for adding this wrapper, it was added twice causing a visual bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1046 introduced two problems to the
SearchControlstrait.Returning
falsefromSearchControls::callHandleRequest()prevents the ipl-webSearchControlstrait from callinghandleRequest()in bothcreateSearchBar()andcreateSearchEditor().An implementation of
createSearchEditor()is added, which explicitly calls$editor->handleRequest()ascreateSearchBar()already does. Without this noSearchEditorin the entire module is usable.An other problem is that moving the call of
$searchbar->handleRequest()also delayed itsassemble(), so this if block was entered before the assemble, resulting in the wrapper being added twice.which caused a visual bug:
The statement should be safe to remove together with the less that has the same
TODO.