Add pending state to cube badges and queries

Include the pending state in host and service status cube queries and render it
in the state badge rows.

Author: jrauh01

library/Cube/CubeRenderer/HostStatusCubeRenderer.php

@@ -32,6 +32,11 @@ public function createFacts(object $facts): HtmlDocument
             $partsObj->hosts_unreachable_unhandled = $facts->hosts_unhandled_unreachable;
         }
 
+        if (isset($facts->hosts_pending) && $facts->hosts_pending > 0) {
+            $parts['pending'] = $facts->hosts_pending;
+            $partsObj->hosts_pending = $facts->hosts_pending;
+        }
+
         if ($facts->hosts_down > 0 && $facts->hosts_down > $facts->hosts_unhandled_down) {
             $downHandled = $facts->hosts_down - $facts->hosts_unhandled_down;
 
@@ -54,12 +59,17 @@ public function createFacts(object $facts): HtmlDocument
         if (
             $facts->hosts_cnt > $facts->hosts_down
             && (! isset($facts->hosts_unreachable) || $facts->hosts_cnt > $facts->hosts_unreachable)
+            && (! isset($facts->hosts_pending) || $facts->hosts_cnt > $facts->hosts_pending)
         ) {
             $ok = $facts->hosts_cnt - $facts->hosts_down;
             if (isset($facts->hosts_unreachable)) {
                 $ok -= $facts->hosts_unreachable;
             }
 
+            if (isset($facts->hosts_pending)) {
+                $ok -= $facts->hosts_pending;
+            }
+
             $parts['ok'] = $ok;
             $partsObj->hosts_up = $ok;
         }

library/Cube/CubeRenderer/ServiceStatusCubeRenderer.php

@@ -37,6 +37,10 @@ public function createFacts(object $facts): HtmlDocument
             $partsObj->services_warning_unhandled = $facts->services_unhandled_warning;
         }
 
+        if (isset($facts->services_pending) && $facts->services_pending > 0) {
+            $partsObj->services_pending = $facts->services_pending;
+        }
+
         if ($facts->services_critical > 0 && $facts->services_critical > $facts->services_unhandled_critical) {
             $criticalHandled = $facts->services_critical - $facts->services_unhandled_critical;
 
@@ -62,10 +66,15 @@ public function createFacts(object $facts): HtmlDocument
             $facts->services_cnt > $facts->services_critical
             && $facts->services_cnt > $facts->services_warning
             && $facts->services_cnt > $facts->services_unknown
+            && (! isset($facts->services_pending) || $facts->services_cnt > $facts->services_pending)
         ) {
             $ok = $facts->services_cnt - $facts->services_critical - $facts->services_warning -
                 $facts->services_unknown;
 
+            if (isset($facts->services_pending)) {
+                $ok -= $facts->services_pending;
+            }
+
             $parts['ok'] = $ok;
             $partsObj->services_ok = $ok;
         }

library/Cube/IcingaDb/IcingaDbHostStatusCube.php

@@ -9,7 +9,6 @@
 use Icinga\Module\Icingadb\Model\Host;
 use Icinga\Module\Icingadb\Model\HoststateSummary;
 use ipl\Stdlib\Filter;
-use ipl\Stdlib\Str;
 
 class IcingaDbHostStatusCube extends IcingaDbCube
 {
@@ -24,6 +23,7 @@ public function getAvailableFactColumns()
             'hosts_cnt' => 'hosts_total',
             'hosts_down' => 'hosts_down_handled + f.hosts_down_unhandled',
             'hosts_unhandled_down' => 'hosts_down_unhandled',
+            'hosts_pending' => 'hosts_pending',
         ];
     }
 

library/Cube/IcingaDb/IcingaDbServiceStatusCube.php

@@ -9,7 +9,6 @@
 use Icinga\Module\Icingadb\Model\Service;
 use Icinga\Module\Icingadb\Model\ServicestateSummary;
 use ipl\Stdlib\Filter;
-use ipl\Stdlib\Str;
 
 class IcingaDbServiceStatusCube extends IcingaDbCube
 {
@@ -39,6 +38,7 @@ public function getAvailableFactColumns()
             'services_unhandled_warning' => 'services_warning_unhandled',
             'services_unknown' => 'services_unknown_handled + f.services_unknown_unhandled',
             'services_unhandled_unknown' => 'services_unknown_unhandled',
+            'services_pending' => 'services_pending'
         ];
     }
 

library/Cube/Web/Widget/HostDimensionWidget.php

@@ -41,6 +41,8 @@ protected function getDimensionClasses(): array
             $severityClass = ['critical'];
         } elseif (isset($sums->hosts_unhandled_unreachable) && $sums->hosts_unhandled_unreachable > 0) {
             $severityClass = ['unreachable'];
+        } elseif (isset($sums->hosts_pending) && $sums->hosts_pending > 0) {
+            $severityClass = ['pending'];
         } elseif ($sums->hosts_down > 0) {
             $severityClass = ['critical', 'handled'];
         } elseif (isset($sums->hosts_unreachable) && $sums->hosts_unreachable > 0) {

library/Cube/Web/Widget/ServiceDimensionWidget.php

@@ -43,6 +43,8 @@ protected function getDimensionClasses(): array
             $severityClass = ['unknown'];
         } elseif ($sums->services_unhandled_warning > 0) {
             $severityClass = ['warning'];
+        } elseif (isset($sums->services_pending) && $sums->services_pending > 0) {
+            $severityClass = ['pending'];
         } elseif ($sums->services_critical > 0) {
             $severityClass = ['critical', 'handled'];
         } elseif ($sums->services_unknown > 0) {

public/css/module.less

@@ -65,6 +65,13 @@ div.cube {
       }
     }
 
+    &.pending {
+      > .header {
+          color: @color-pending;
+          border-color: @color-pending;
+      }
+    }
+
     &.ok {
       > .header {
           color: @color-ok;
@@ -141,6 +148,10 @@ div.cube {
       }
     }
 
+    &.pending {
+      border-left-color: @color-pending;
+    }
+
     &.ok {
       border-left-color: @color-ok;
     }
@@ -203,6 +214,10 @@ div.cube {
       }
     }
 
+    &.pending {
+      background: @color-pending;
+    }
+
     &.ok {
       background: @color-ok;
     }
@@ -219,7 +234,7 @@ div.cube {
   }
 
   span {
-    &.critical, &.warning, &.unknown, &.unreachable, &.ok {
+    &.critical, &.warning, &.unknown, &.unreachable, &.pending, &.ok {
       display: inline;
       border-radius: 0.1em;
       padding: 0.05em 0.2em;
@@ -259,6 +274,10 @@ div.cube {
       }
     }
 
+    &.pending {
+      background: @color-pending;
+    }
+
     &.ok {
       background: @color-ok;
     }